Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2558993004: Remove some unused declarations. (Closed)

Created:
4 years ago by nigeltao1
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused declarations. BUG= Committed: https://crrev.com/50f24062f7cb3b65011512fed6a422609e100f16 Cr-Commit-Position: refs/heads/master@{#437693}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/renderer/chrome_render_thread_observer.h View 2 chunks +0 lines, -6 lines 2 comments Download

Messages

Total messages: 20 (13 generated)
nigeltao1
4 years ago (2016-12-08 23:42:47 UTC) #2
sky
https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_render_thread_observer.h File chrome/renderer/chrome_render_thread_observer.h (left): https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_render_thread_observer.h#oldcode60 chrome/renderer/chrome_render_thread_observer.h:60: void OnSetContentSettingsForCurrentURL( Something tells me this is from your ...
4 years ago (2016-12-09 00:22:05 UTC) #7
nigeltao1
https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_render_thread_observer.h File chrome/renderer/chrome_render_thread_observer.h (left): https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_render_thread_observer.h#oldcode60 chrome/renderer/chrome_render_thread_observer.h:60: void OnSetContentSettingsForCurrentURL( On 2016/12/09 00:22:04, sky wrote: > Something ...
4 years ago (2016-12-09 05:03:08 UTC) #10
sky
LGTM
4 years ago (2016-12-09 16:07:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558993004/1
4 years ago (2016-12-09 22:27:48 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 23:34:53 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 14:58:24 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50f24062f7cb3b65011512fed6a422609e100f16
Cr-Commit-Position: refs/heads/master@{#437693}

Powered by Google App Engine
This is Rietveld 408576698