|
|
DescriptionRemove some unused declarations.
BUG=
Committed: https://crrev.com/50f24062f7cb3b65011512fed6a422609e100f16
Cr-Commit-Position: refs/heads/master@{#437693}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (13 generated)
nigeltao@chromium.org changed reviewers: + sky@chromium.org
The CQ bit was checked by nigeltao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_rend... File chrome/renderer/chrome_render_thread_observer.h (left): https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_rend... chrome/renderer/chrome_render_thread_observer.h:60: void OnSetContentSettingsForCurrentURL( Something tells me this is from your other patch.
The CQ bit was checked by nigeltao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_rend... File chrome/renderer/chrome_render_thread_observer.h (left): https://codereview.chromium.org/2558993004/diff/1/chrome/renderer/chrome_rend... chrome/renderer/chrome_render_thread_observer.h:60: void OnSetContentSettingsForCurrentURL( On 2016/12/09 00:22:04, sky wrote: > Something tells me this is from your other patch. It's not. The CQ dry run failures were from something else breaking the build.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by nigeltao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481322406274510, "parent_rev": "9a2968be362b589663cdd56f9eecdab09fede9a4", "commit_rev": "bc797ba041e2d870a70f88fbe6523d1dcbe4865b"}
Message was sent while issue was closed.
Description was changed from ========== Remove some unused declarations. BUG= ========== to ========== Remove some unused declarations. BUG= Review-Url: https://codereview.chromium.org/2558993004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove some unused declarations. BUG= Review-Url: https://codereview.chromium.org/2558993004 ========== to ========== Remove some unused declarations. BUG= Committed: https://crrev.com/50f24062f7cb3b65011512fed6a422609e100f16 Cr-Commit-Position: refs/heads/master@{#437693} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/50f24062f7cb3b65011512fed6a422609e100f16 Cr-Commit-Position: refs/heads/master@{#437693} |