Billing address not required for canMakePayment().

Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926
Committed: https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13
Cr-Commit-Position: refs/heads/master@{#439486}

[please use gerrit instead, 2016-12-08 20:41:29]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 20:42:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:17:57]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-12-15 22:56:41]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:57:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 00:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:49:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-12-16 15:22:23]

Description was changed from

==========
Billing address not required for canMakePayment().

If the user has a credit card on file that does not have a billing
address set, then merchant's call canMakePayment() should return true.
(Billing address was required before this patch.)

BUG=664619
==========

to

==========
Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926
==========

[please use gerrit instead, 2016-12-16 15:22:35]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:22:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-12-16 15:22:58]

Patchset #2 (id:20001) has been deleted

[please use gerrit instead, 2016-12-16 15:23:04]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-12-16 15:25:45]

rouslan@chromium.org changed reviewers:
+ gogerald@chromium.org

[please use gerrit instead, 2016-12-16 15:25:46]

PTAL.

[commit-bot: I haz the power, 2016-12-16 16:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 16:16:46]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-12-16 22:34:40]

get a suggestion :-),

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:45:
private boolean mIsValidNumberAndName;
mHasValidNumberAndName or mIsNumberAndNameValid?

I am thinking can we just add a new interface 'isValid' which means the
instrument has correct name and number. And we already have 'isComplete' which
means the instrument is ready to be send to merchant. Looks more clear to me.

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:228:
public boolean hasValidBillingAddress() {
No need this interface.

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1281:
if (creditCard.hasValidBillingAddress()) selection = 0;
you can move this if statement out of the parent if statement by using
"isComplete"

[please use gerrit instead, 2016-12-19 15:16:07]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-12-19 15:16:16]

Ganggui, ptal patch 2.

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:45:
private boolean mIsValidNumberAndName;
On 2016/12/16 22:34:40, gogerald1 wrote:
> mHasValidNumberAndName or mIsNumberAndNameValid?
> 
> I am thinking can we just add a new interface 'isValid' which means the
> instrument has correct name and number. And we already have 'isComplete' which
> means the instrument is ready to be send to merchant. Looks more clear to me.

Done.

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:228:
public boolean hasValidBillingAddress() {
On 2016/12/16 22:34:40, gogerald1 wrote:
> No need this interface.

Done.

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2558993003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1281:
if (creditCard.hasValidBillingAddress()) selection = 0;
On 2016/12/16 22:34:40, gogerald1 wrote:
> you can move this if statement out of the parent if statement by using
> "isComplete"

Done.

[commit-bot: I haz the power, 2016-12-19 15:16:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 15:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 15:46:54]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-12-19 15:47:46]

lgtm

[please use gerrit instead, 2016-12-19 16:20:04]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-12-19 16:20:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 16:23:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482164404471630,
"parent_rev": "0afe5b584e8143d541bdc6c16fc09e6443ec7a46", "commit_rev":
"3dd553967e2641ad50fc6f32d67e9207fffde7b9"}

[commit-bot: I haz the power, 2016-12-19 16:23:52]

Description was changed from

==========
Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926
==========

to

==========
Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926

Review-Url: https://codereview.chromium.org/2558993003
==========

[commit-bot: I haz the power, 2016-12-19 16:23:53]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-12-19 16:26:21]

Description was changed from

==========
Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926

Review-Url: https://codereview.chromium.org/2558993003
==========

to

==========
Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926

Committed: https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13
Cr-Commit-Position: refs/heads/master@{#439486}
==========

[commit-bot: I haz the power, 2016-12-19 16:26:22]

Patchset 2 (id:??) landed as
https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13
Cr-Commit-Position: refs/heads/master@{#439486}