Remove the enable_mac_keystone build flag.

Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706
Committed: https://crrev.com/cee2ef7eac5b521699ba2a6c4c494ecb2d91b042
Cr-Commit-Position: refs/heads/master@{#437687}

[brettw, 2016-12-08 00:16:43]

Fix

[brettw, 2016-12-08 00:16:43]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:17:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-12-08 00:18:09]

brettw@chromium.org changed reviewers:
+ shrike@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:11:39]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-12-08 20:28:45]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-12-08 20:28:48]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-12-09 00:54:54]

Ping?

[shrike, 2016-12-09 20:25:30]

Description was changed from

==========
Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706
==========

to

==========
Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706
==========

[shrike, 2016-12-09 20:25:30]

shrike@chromium.org changed reviewers:
+ mark@chromium.org

[shrike, 2016-12-09 20:26:20]

On 2016/12/09 00:54:54, brettw (ping after 24h) wrote:
> Ping?

Seems reasonable if it's rarely used, but it's better to confirm with mark@.

[Mark Mentovai, 2016-12-09 20:57:14]

is_chrome_branded is alone sufficient to require a src-internal checkout, right?
If so, LGTM.

[brettw, 2016-12-09 21:07:45]

Correct. Thanks.

[brettw, 2016-12-09 21:07:48]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-12-09 21:09:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 23:25:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481317668145060,
"parent_rev": "3083387f86148ae3ee30ab2f98a88158462daca4", "commit_rev":
"5766bcaef8d069a69c31a1451b72923070f9b340"}

[commit-bot: I haz the power, 2016-12-09 23:25:57]

Description was changed from

==========
Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706
==========

to

==========
Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706

Review-Url: https://codereview.chromium.org/2558973003
==========

[commit-bot: I haz the power, 2016-12-09 23:26:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 14:58:12]

Description was changed from

==========
Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706

Review-Url: https://codereview.chromium.org/2558973003
==========

to

==========
Remove the enable_mac_keystone build flag.

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706

Committed: https://crrev.com/cee2ef7eac5b521699ba2a6c4c494ecb2d91b042
Cr-Commit-Position: refs/heads/master@{#437687}
==========

[commit-bot: I haz the power, 2016-12-12 14:58:13]

Patchset 2 (id:??) landed as
https://crrev.com/cee2ef7eac5b521699ba2a6c4c494ecb2d91b042
Cr-Commit-Position: refs/heads/master@{#437687}