Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2558963003: Add GetCurrentRoutes() to MediaRouter API, ensure dialog has routes at init (Closed)

Created:
4 years ago by imcheng
Modified:
4 years ago
Reviewers:
tapted
CC:
chromium-reviews, tapted
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add GetCurrentRoutes() to MediaRouter API, ensure dialog has routes at init This CL adds a method to the MediaRouter interface to get the current media routes synchronously. We call this if MediaRouterUI hasn't observed routes updates yet when the dialog WebUI asks for initial data, to ensure that WebUI has routes information at initialization. BUG=667361 Review-Url: https://codereview.chromium.org/2540773005 Cr-Commit-Position: refs/heads/master@{#436366} (cherry picked from commit 21ad18d7d165fe60792c5c5e3c56b0647324c03c) Committed: https://chromium.googlesource.com/chromium/src/+/56bae1de1137687fc84d8d6f251a196545bb021d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -110 lines) Patch
M chrome/browser/media/router/media_router.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_base.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_base.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_base_unittest.cc View 4 chunks +50 lines, -15 lines 0 comments Download
M chrome/browser/media/router/mock_media_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.h View 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 4 chunks +46 lines, -39 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 6 chunks +25 lines, -46 lines 1 comment Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
imcheng
Committed patchset #1 (id:1) manually as 56bae1de1137687fc84d8d6f251a196545bb021d.
4 years ago (2016-12-07 22:34:17 UTC) #2
tapted
https://codereview.chromium.org/2558963003/diff/1/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc File chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc (right): https://codereview.chromium.org/2558963003/diff/1/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc#newcode280 chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc:280: CreateMediaRouterUI(profile()); This is causing a compile failure on go/betabuilders ...
4 years ago (2016-12-08 05:09:23 UTC) #4
imcheng
4 years ago (2016-12-08 05:34:57 UTC) #5
Message was sent while issue was closed.
This is already fixed with https://codereview.chromium.org/2559043002

Powered by Google App Engine
This is Rietveld 408576698