Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4727)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.h

Issue 2558963003: Add GetCurrentRoutes() to MediaRouter API, ensure dialog has routes at init (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.h
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.h b/chrome/browser/ui/webui/media_router/media_router_ui.h
index dd329318b9f080aece510d8be5b168f4ab7758cc..910dee66aa04296ef3a4a75af71f36e68f8bca06 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.h
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.h
@@ -140,9 +140,9 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
return joinable_route_ids_;
}
const std::set<MediaCastMode>& cast_modes() const { return cast_modes_; }
- const std::unordered_map<MediaRoute::Id, MediaCastMode>& current_cast_modes()
- const {
- return current_cast_modes_;
+ const std::unordered_map<MediaRoute::Id, MediaCastMode>&
+ routes_and_cast_modes() const {
+ return routes_and_cast_modes_;
}
const content::WebContents* initiator() const { return initiator_; }
@@ -165,10 +165,8 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
private:
FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest, SortedSinks);
FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest, SortSinksByIconType);
- FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest,
- UIMediaRoutesObserverFiltersNonDisplayRoutes);
- FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest,
- UIMediaRoutesObserverFiltersNonDisplayJoinableRoutes);
+ FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest, FilterNonDisplayRoutes);
+ FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest, FilterNonDisplayJoinableRoutes);
FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest,
UIMediaRoutesObserverAssignsCurrentCastModes);
FRIEND_TEST_ALL_PREFIXES(MediaRouterUITest,
@@ -272,6 +270,10 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
// |handler_|.
void UpdateCastModes();
+ // Updates the routes-to-cast-modes mapping in |routes_and_cast_modes_| to
+ // match the value of |routes_|.
+ void UpdateRoutesToCastModesMapping();
+
// Returns the default presentation request's frame URL if there is one.
// Otherwise returns an empty GURL.
GURL GetFrameURL() const;
@@ -303,7 +305,7 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
std::vector<MediaRoute> routes_;
std::vector<MediaRoute::Id> joinable_route_ids_;
CastModeSet cast_modes_;
- std::unordered_map<MediaRoute::Id, MediaCastMode> current_cast_modes_;
+ std::unordered_map<MediaRoute::Id, MediaCastMode> routes_and_cast_modes_;
std::unique_ptr<QueryResultManager> query_result_manager_;

Powered by Google App Engine
This is Rietveld 408576698