Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2558903002: Chrome OS select-to-speak feature not properly handling key repeat (Closed)

Created:
4 years ago by dmazzoni
Modified:
4 years ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS select-to-speak feature not properly handling key repeat The select-to-speak feature is triggered when holding down the Search key and clicking or dragging. Holding down Search generates additional key press events due to key repeat, which was resetting the state in the middle of a drag. Fix this and add a test. BUG=593887 Committed: https://crrev.com/1e25a7de67ab94077def5f8f9b7672ca72f46070 Cr-Commit-Position: refs/heads/master@{#437275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dmazzoni
4 years ago (2016-12-07 18:24:04 UTC) #2
David Tseng
lgtm
4 years ago (2016-12-08 17:31:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558903002/1
4 years ago (2016-12-08 17:33:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 17:39:24 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 17:41:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e25a7de67ab94077def5f8f9b7672ca72f46070
Cr-Commit-Position: refs/heads/master@{#437275}

Powered by Google App Engine
This is Rietveld 408576698