Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc

Issue 2558903002: Chrome OS select-to-speak feature not properly handling key repeat (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
diff --git a/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc b/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
index 0c4487588e42d3b5717886c83f95f12e21ac3869..27bab6298d4cd19d80076ce00ed709e2fbc050f1 100644
--- a/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
+++ b/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
@@ -27,7 +27,7 @@ SelectToSpeakEventHandler::~SelectToSpeakEventHandler() {
void SelectToSpeakEventHandler::OnKeyEvent(ui::KeyEvent* event) {
if (event->key_code() == ui::VKEY_LWIN) {
- if (event->type() == ui::ET_KEY_PRESSED) {
+ if (event->type() == ui::ET_KEY_PRESSED && state_ == INACTIVE) {
state_ = SEARCH_DOWN;
} else if (event->type() == ui::ET_KEY_RELEASED) {
if (state_ == CAPTURING) {
« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698