Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 25589003: Bootstrap to extend WTF:RefPtr's run-time adoption checking to skia's SkRefCnt (Closed)

Created:
7 years, 2 months ago by Justin Novosad
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium, reed1, Stephen White
Visibility:
Public.

Description

Bootstrap to extend WTF:RefPtr's run-time adoption checking to skia's SkRefCnt With this change, refIfNotNull will now call RequireAdoption on the referenced object in order to enable run-time adoption checking. This is essential for skia's SkRefCnt, which cannot have adoption checks enabled by default because skia does not always use smart pointers internally, and has no explicit notion of reference adoption. BUG=304265 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159028

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename adoptionRequired -> requireAdoption #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Source/wtf/PassRefPtr.h View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Justin Novosad
PTAL Companion skia CL: https://codereview.chromium.org/25432003
7 years, 2 months ago (2013-10-04 20:14:04 UTC) #1
abarth-chromium
Neat! https://codereview.chromium.org/25589003/diff/1/Source/wtf/PassRefPtr.h File Source/wtf/PassRefPtr.h (right): https://codereview.chromium.org/25589003/diff/1/Source/wtf/PassRefPtr.h#newcode43 Source/wtf/PassRefPtr.h:43: inline void adoptionRequired(const void*) { } adoptionRequired -> ...
7 years, 2 months ago (2013-10-04 20:37:58 UTC) #2
Justin Novosad
On 2013/10/04 20:37:58, abarth wrote: > As named, it sounds like it would return a ...
7 years, 2 months ago (2013-10-04 21:19:54 UTC) #3
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-05 00:09:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/25589003/6001
7 years, 2 months ago (2013-10-05 00:09:48 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=9075
7 years, 2 months ago (2013-10-05 02:22:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/25589003/6001
7 years, 2 months ago (2013-10-07 13:21:05 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 14:05:15 UTC) #8
Message was sent while issue was closed.
Change committed as 159028

Powered by Google App Engine
This is Rietveld 408576698