[wasm][asm.js] Fail sooner if eval is present.

src/asmjs/asm-typer.cc

Index: src/asmjs/asm-typer.cc
diff --git a/src/asmjs/asm-typer.cc b/src/asmjs/asm-typer.cc
index dff43b7db61bf4c402a2dfd3fd774cfb11c8641c..b10f6de5ffe3f7515869582deabf6ec7031124d8 100644
--- a/src/asmjs/asm-typer.cc
+++ b/src/asmjs/asm-typer.cc
@@ -583,6 +583,10 @@ AsmType* AsmTyper::ValidateModuleBeforeFunctionsPhase(FunctionLiteral* fun) {
     Variable* param = scope->parameter(ii);
     DCHECK(param);
 
+    if (param->location() != VariableLocation::PARAMETER) {

[titzer, 2016/12/08 10:39:54]

I don't think this is the check you want. There are some predicates on the scope
that it contains an eval (or that an inner scope contains eval). I think you
want to use those.

[bradn, 2016/12/08 10:53:24]

Done.

+      FAIL(fun, "Invalid asm.js module using eval.");
+    }
+
     if (!ValidAsmIdentifier(param->name())) {
       FAIL(fun, "Invalid asm.js identifier in module parameter.");
     }