[wasm][asm.js] Fail sooner if eval is present.

src/asmjs/asm-typer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/asmjs/asm-typer.h"
 
 #include <algorithm>
 #include <limits>
 #include <memory>
 #include <string>
@@ skipping 565 matching lines @@
   struct {
     StandardMember standard_member;
   } kModuleParamInfo[3] = {
       {kStdlib}, {kFFI}, {kHeap},
   };
 
   for (int ii = 0; ii < scope->num_parameters(); ++ii) {
     Variable* param = scope->parameter(ii);
     DCHECK(param);
 
+    if (param->location() != VariableLocation::PARAMETER) {

[titzer, 2016/12/08 10:39:54]

I don't think this is the check you want. There are some predicates on the scope
that it contains an eval (or that an inner scope contains eval). I think you
want to use those.

[bradn, 2016/12/08 10:53:24]

Done.

+      FAIL(fun, "Invalid asm.js module using eval.");
+    }
+
     if (!ValidAsmIdentifier(param->name())) {
       FAIL(fun, "Invalid asm.js identifier in module parameter.");
     }
 
     auto* param_info = VariableInfo::ForSpecialSymbol(
         zone_, kModuleParamInfo[ii].standard_member);
 
     if (!AddGlobal(param, param_info)) {
       FAIL(fun, "Redeclared identifier in module parameter.");
     }
@@ skipping 2283 matching lines @@
     return true;
   }
 
   *error_message = typer.error_message();
   return false;
 }
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8