Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2558683002: Revert of Support margin-top for legend in fieldset. (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
cbiesinger, ikilpatrick, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, eae, Karl Øygard
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support margin-top for legend in fieldset. (patchset #5 id:80001 of https://codereview.chromium.org/2396813002/ ) Reason for revert: need to revert the previously landed patch http://crrev.com/415577 that blocks the release Original issue's description: > Support margin-top for legend in fieldset. > > The implementation aligns with Edge, Gecko centers the legend+margins, which > looks undesirable to me. The specs say nothing about this. > > The new behaviour causes two tests to change, both have been rebaselined. One > was additionally modified to not trigger the scrollbar, which in turn would > render differently on various platforms. > > BUG=554077 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/462e2f8e1a0f0a09efa7c8bcc34da36fd7b532ca > Cr-Commit-Position: refs/heads/master@{#425127} TBR=eae@chromium.org,karlo@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=554077 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/3cf008740d9f33e8f659a4cb132a7e93551a86a0 Cr-Commit-Position: refs/heads/master@{#436891}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -180 lines) Patch
M third_party/WebKit/LayoutTests/fast/block/basic/fieldset-stretch-to-legend.html View 1 1 chunk +62 lines, -69 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/basic/fieldset-stretch-to-legend-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/basic/fieldset-stretch-to-legend-expected.txt View 1 chunk +61 lines, -63 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-before-in-fieldset.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-before-in-fieldset-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/block/basic/fieldset-stretch-to-legend-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/block/basic/fieldset-stretch-to-legend-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/borders/fieldsetBorderRadius-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/block/basic/fieldset-stretch-to-legend-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 1 1 chunk +18 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 1 2 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 35 (28 generated)
Gleb Lanbin
Created Revert of Support margin-top for legend in fieldset.
4 years ago (2016-12-06 23:54:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558683002/1
4 years ago (2016-12-06 23:55:10 UTC) #3
ikilpatrick
lgtm
4 years ago (2016-12-07 00:17:10 UTC) #17
eae
LGTM
4 years ago (2016-12-07 07:19:25 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558683002/260001
4 years ago (2016-12-07 07:53:51 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years ago (2016-12-07 07:58:10 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-07 08:00:43 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cf008740d9f33e8f659a4cb132a7e93551a86a0
Cr-Commit-Position: refs/heads/master@{#436891}

Powered by Google App Engine
This is Rietveld 408576698