Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Issue 2558673003: Move RequestQuotaPermission from RenderView to RenderFrame. (Closed)

Created:
4 years ago by ncarter (slow)
Modified:
4 years ago
Reviewers:
jam, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mlamouri+watch-permissions_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RequestQuotaPermission from RenderView to RenderFrame. BUG=560438 Committed: https://crrev.com/6206d82a6af7b8ffe9e58fa99170cae7763968a3 Cr-Commit-Position: refs/heads/master@{#437615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/child/quota_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/quota_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/quota_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/storage_quota_params.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
ncarter (slow)
Nasko, WDYT?
4 years ago (2016-12-07 00:26:03 UTC) #4
nasko
LGTM
4 years ago (2016-12-07 01:16:52 UTC) #5
ncarter (slow)
+jam for chrome/browser/chrome_quota_permission_context.cc
4 years ago (2016-12-08 18:37:27 UTC) #9
jam
lgtm
4 years ago (2016-12-08 23:44:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558673003/1
4 years ago (2016-12-08 23:46:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/177546) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-08 23:55:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558673003/1
4 years ago (2016-12-09 18:14:21 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:05:38 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-12 14:37:08 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6206d82a6af7b8ffe9e58fa99170cae7763968a3
Cr-Commit-Position: refs/heads/master@{#437615}

Powered by Google App Engine
This is Rietveld 408576698