Add Kernel Isolate

Add Kernel Isolate, second attempt

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages  foo.dart

The front end expects a directory named patched_sdk in the build directory (patched_sdk should be a sibling of the directory that contains the dart executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to run Hello World in a debug build, and about 7 seconds in a release build.



BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/f5ab173c770a8fd26de7c236937cfa3be9035da1

[hausner, 2016-12-06 23:45:27]

Description was changed from

==========
Add Kernel Isolate

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages 
foo.dart

The front end expects a directory named patched_sdk in the build directory
(patched_sdk should be a sibling of the directory that contains the dart
executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to
run Hello World in a debug build, and about 7 seconds in a release build.


This reverts commit 2ea399285a615de3e5e9d84fa67fec6736d15404.


BUG=
==========

to

==========
Add Kernel Isolate, second attempt

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages 
foo.dart

The front end expects a directory named patched_sdk in the build directory
(patched_sdk should be a sibling of the directory that contains the dart
executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to
run Hello World in a debug build, and about 7 seconds in a release build.


This reverts commit 2ea399285a615de3e5e9d84fa67fec6736d15404.


BUG=
==========

[hausner, 2016-12-06 23:45:27]

hausner@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-12-07 00:46:39]

lgtm

https://codereview.chromium.org/2558673002/diff/1/runtime/vm/kernel_isolate.cc
File runtime/vm/kernel_isolate.cc (right):

https://codereview.chromium.org/2558673002/diff/1/runtime/vm/kernel_isolate.c...
runtime/vm/kernel_isolate.cc:191: monitor_ = new Monitor();
might make sense to pull this up to the top declaration as this is a static
field. The we won't have to worry about people calling KernelIsolate::IsRunning
or KernelIsolate::Exists before KernelIsolate::Run is called.

https://codereview.chromium.org/2558673002/diff/1/runtime/vm/kernel_isolate.c...
runtime/vm/kernel_isolate.cc:210: // Not service isolate.
Should the comment be 'Not kernel isolate.'?

[hausner, 2016-12-07 17:01:29]

Thank you.

https://codereview.chromium.org/2558673002/diff/1/runtime/vm/kernel_isolate.cc
File runtime/vm/kernel_isolate.cc (right):

https://codereview.chromium.org/2558673002/diff/1/runtime/vm/kernel_isolate.c...
runtime/vm/kernel_isolate.cc:191: monitor_ = new Monitor();
On 2016/12/07 00:46:38, siva wrote:
> might make sense to pull this up to the top declaration as this is a static
> field. The we won't have to worry about people calling
KernelIsolate::IsRunning
> or KernelIsolate::Exists before KernelIsolate::Run is called.

Done.

https://codereview.chromium.org/2558673002/diff/1/runtime/vm/kernel_isolate.c...
runtime/vm/kernel_isolate.cc:210: // Not service isolate.
On 2016/12/07 00:46:38, siva wrote:
> Should the comment be 'Not kernel isolate.'?

Done.

[hausner, 2016-12-07 17:01:52]

Description was changed from

==========
Add Kernel Isolate, second attempt

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages 
foo.dart

The front end expects a directory named patched_sdk in the build directory
(patched_sdk should be a sibling of the directory that contains the dart
executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to
run Hello World in a debug build, and about 7 seconds in a release build.


This reverts commit 2ea399285a615de3e5e9d84fa67fec6736d15404.


BUG=
==========

to

==========
Add Kernel Isolate, second attempt

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages 
foo.dart

The front end expects a directory named patched_sdk in the build directory
(patched_sdk should be a sibling of the directory that contains the dart
executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to
run Hello World in a debug build, and about 7 seconds in a release build.



BUG=
==========

[hausner, 2016-12-07 17:11:19]

Description was changed from

==========
Add Kernel Isolate, second attempt

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages 
foo.dart

The front end expects a directory named patched_sdk in the build directory
(patched_sdk should be a sibling of the directory that contains the dart
executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to
run Hello World in a debug build, and about 7 seconds in a release build.



BUG=
==========

to

==========
Add Kernel Isolate, second attempt

To run a script with the Dart->Kernel parser, use the -dfe option:

dart --dfe=runtime/tools/kernel-service.dart  --packages=/src/d2/sdk/.packages 
foo.dart

The front end expects a directory named patched_sdk in the build directory
(patched_sdk should be a sibling of the directory that contains the dart
executable.)

Warning: using a debug build dart executable is very slow. It takes 2 minutes to
run Hello World in a debug build, and about 7 seconds in a release build.



BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f5ab173c770a8fd26de7c236937cfa3be9035da1
==========

[hausner, 2016-12-07 17:11:22]

Committed patchset #2 (id:20001) manually as
f5ab173c770a8fd26de7c236937cfa3be9035da1 (presubmit successful).

[kasperl, 2016-12-08 11:44:26]

kasperl@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2016-12-08 11:44:27]

DBC

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
File runtime/tools/kernel-service.dart (right):

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:21: final RawReceivePort scriptLoadPort = new
RawReceivePort();
Why is this not just stored in a local variable in main?

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:36: void checkSdkDirectory(String path) {
bool

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:49: var buffer = [];
There is a lot of copying of the bytes produced by the BinaryPrinter happening
here and behind the scenes. Also, this buffer is a regular list which means that
we will smi-encode all the bytes.

Should we have a separate BinaryPrinter that produces the bytes in a Uint8List
directly, so we can avoid all this copying and 8x data blow up on 64-bit
platforms? The BytesBuilder class in dart:io
(https://api.dartlang.org/stable/1.21.0/dart-io/BytesBuilder-class.html) might
come in handy.

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:71: 
Remove empty line.

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:97: // Link program into one file, cf. --link
option in dartk
Terminate comment with .

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:115: Uri patched_sdk =
Uri.parse(Platform.resolvedExecutable).resolve("patched_sdk");
Long line.

patched_sdk -> patchedSdk

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:121: var msg = new List(5);
sp.send([tag, inputFileUrl, inputFileUrl, null, data]);

(unless the receiver side cannot deal with growable lists)

Why is the inputFileUrl included twice in the reply and why is there a null in
there? Maybe deserves a comment here?

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:128: return;
What's the intent with this return?

https://codereview.chromium.org/2558673002/diff/20001/runtime/tools/kernel-se...
runtime/tools/kernel-service.dart:131: var msg = new List(5);
sp.send([-tag, inputFileUrl, inputFileUrl, null, e.toString()])?