Add Kernel Isolate

runtime/tools/kernel-service.dart

+// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// This is an interface to the Dart Kernel parser and Kernel binary generator.
+// It is used by the kernel-isolate to load Dart source code and generate
+// Kernel binary format.
+
+import 'dart:isolate';
+import 'dart:async';
+import "dart:io";
+import "dart:typed_data";
+
+import 'package:kernel/binary/ast_to_binary.dart';
+import 'package:kernel/analyzer/loader.dart';
+import 'package:kernel/kernel.dart';
+import 'package:kernel/target/targets.dart';
+
+bool verbose = false;
+
+final RawReceivePort scriptLoadPort = new RawReceivePort();

[kasperl, 2016/12/08 11:44:27]

Why is this not just stored in a local variable in main?

+
+
+bool checkIsFile(String path) {
+  var stat = new File(path).statSync();
+  switch (stat.type) {
+    case FileSystemEntityType.DIRECTORY:
+      return false;
+    case FileSystemEntityType.NOT_FOUND:
+      return false;
+  }
+  return true;
+}
+
+
+void checkSdkDirectory(String path) {

[kasperl, 2016/12/08 11:44:27]

bool

+  var stat = new File(path).statSync();
+  switch (stat.type) {
+    case FileSystemEntityType.DIRECTORY:
+    case FileSystemEntityType.LINK:
+      return true;
+    default:
+      return false;
+  }
+}
+
+
+class DataSink implements StreamSink<List<int>> {
+  var buffer = [];

[kasperl, 2016/12/08 11:44:27]

There is a lot of copying of the bytes produced by the BinaryPrinter happening
here and behind the scenes. Also, this buffer is a regular list which means that
we will smi-encode all the bytes.

Should we have a separate BinaryPrinter that produces the bytes in a Uint8List
directly, so we can avoid all this copying and 8x data blow up on 64-bit
platforms? The BytesBuilder class in dart:io
(https://api.dartlang.org/stable/1.21.0/dart-io/BytesBuilder-class.html) might
come in handy.

+  add(List<int> data) {
+    buffer.addAll(data);
+  }
+  close() {
+    // Nothing to do.
+  }
+}
+
+
+List writeProgramToBuffer(Program program) {
+  var sink = new DataSink();
+  try {
+    new BinaryPrinter(sink).writeProgramFile(program);
+  } finally {
+    sink.close();
+  }
+  return new Uint8List.fromList(sink.buffer);
+}
+
+
+Future parseScript(Uri fileName, String packageConfig, String sdkPath) async {
+

[kasperl, 2016/12/08 11:44:27]

Remove empty line.

+  if (!checkIsFile(fileName.path)) {
+    throw "Input file '${fileName.path}' does not exist.";
+  }
+
+  if (!checkSdkDirectory(sdkPath)) {
+    throw "Patched sdk directory not found at $sdkPath";
+  }
+
+  Target target = getTarget("vm", new TargetFlags(strongMode: false));
+  DartOptions dartOptions = new DartOptions(
+        strongMode: false,
+        strongModeSdk: false,
+        sdk: sdkPath,
+        packagePath: packageConfig,
+        customUriMappings: {},
+        declaredVariables: {});
+  DartLoader loader =
+      await new DartLoaderBatch().getLoader(new Repository(), dartOptions);
+  var program = loader.loadProgram(fileName, target: target);
+
+  var errors = loader.errors;
+  if (errors.isNotEmpty) {
+    throw loader.errors.first;
+  }
+
+  // Link program into one file, cf. --link option in dartk

[kasperl, 2016/12/08 11:44:27]

Terminate comment with .

+  target.transformProgram(program);
+
+  return writeProgramToBuffer(program);
+}
+
+
+_processLoadRequest(request) {
+  if (verbose) {
+    print("FROM DART KERNEL: load request: $request");
+    print("FROM DART KERNEL: package: ${Platform.packageConfig}");
+    print("FROM DART KERNEL: exec: ${Platform.resolvedExecutable}");
+  }
+  int tag = request[0];
+  SendPort sp = request[1];
+  String inputFileUrl = request[2];
+  Uri scriptUri = Uri.parse(inputFileUrl);
+  Uri packagesUri = Uri.parse(Platform.packageConfig ?? ".packages");
+  Uri patched_sdk = Uri.parse(Platform.resolvedExecutable).resolve("patched_sdk");

[kasperl, 2016/12/08 11:44:27]

Long line.

patched_sdk -> patchedSdk

+
+  var parsingDone = parseScript(scriptUri, packagesUri.path, patched_sdk.path);
+
+  parsingDone
+    .then((data) {
+        var msg = new List(5);

[kasperl, 2016/12/08 11:44:27]

sp.send([tag, inputFileUrl, inputFileUrl, null, data]);

(unless the receiver side cannot deal with growable lists)

Why is the inputFileUrl included twice in the reply and why is there a null in
there? Maybe deserves a comment here?

+        msg[0] = tag;
+        msg[1] = inputFileUrl;
+        msg[2] = inputFileUrl;
+        msg[3] = null;
+        msg[4] = data;
+        sp.send(msg);
+        return;

[kasperl, 2016/12/08 11:44:27]

What's the intent with this return?

+    })
+    .catchError((e) {
+        var msg = new List(5);

[kasperl, 2016/12/08 11:44:27]

sp.send([-tag, inputFileUrl, inputFileUrl, null, e.toString()])?

+        msg[0] = -tag;
+        msg[1] = inputFileUrl;
+        msg[2] = inputFileUrl;
+        msg[3] = null;
+        msg[4] = e.toString();
+        sp.send(msg);
+    });
+}
+
+
+main() {
+  scriptLoadPort.handler = _processLoadRequest;
+  Timer.run(() {});
+  return scriptLoadPort;
+}