[InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

Index: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
diff --git a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
index a4305db054aef75522ab92ba24195094d6241825..e52fd5483fea830cb49b1aa5637cd0cd9aa382b3 100644
--- a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
+++ b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
@@ -115,6 +115,13 @@ DataTransfer* DataTransfer::create(DataTransferType type,
   return new DataTransfer(type, policy, dataObject);
 }
 
+DataTransfer* DataTransfer::createForInputEvent(const String& plainText,
+                                                const String& htmlText) {
+  return new DataTransfer(
+      InputEvent, DataTransferReadable,

[Xiaocheng, 2016/12/22 06:26:20]

Hmm... This is a behavior change.

We were creating DataTransfers with DragAndDrop and InsertReplacementText for
beforeinput, but now they both become InputEvent.

The working draft doesn't say anything about InputEvent's DataTransfer,
though...

Anyway, could you clarify?

[chongz, 2016/12/22 19:32:26]

Sorry for the confusion, there is actually no behavior change.

Originally |DataTransfer| was used by 2 events:
1. ClipboardEvent
(https://w3c.github.io/clipboard-apis/#clipboard-event-interfaces)
  * e.g. 'copy', 'paste'
2. DragEvent (https://html.spec.whatwg.org/multipage/interaction.html#dragevent)
  * 'e.g. 'dragstart', 'drop', etc.

Now we are adding |InputEvent| which would also use |DataTransfer|.
There is no conflicts because |InputEvent::'deleteByDrag'| etc. are new events
and they are not going to replace drag&drop events.

To help reducing future confusion I think we should change |DataTransferType|
to:
```
enum DataTransferType {
    ClipboardEvent,
    DragEvent,
    InputEvent,
  };
```
Or even just change it to `bool m_isDragEvent;` as we only using it internally
for activating drop effect, etc.

+      DataObject::createFromPlainTextAndHTML(plainText, htmlText));
+}
+
 DataTransfer::~DataTransfer() {}
 
 void DataTransfer::setDropEffect(const String& effect) {