[InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 97 matching lines @@
   }
   return cleanType;
 }
 
 DataTransfer* DataTransfer::create(DataTransferType type,
                                    DataTransferAccessPolicy policy,
                                    DataObject* dataObject) {
   return new DataTransfer(type, policy, dataObject);
 }
 
+DataTransfer* DataTransfer::createForInputEvent(const String& plainText,
+                                                const String& htmlText) {
+  return new DataTransfer(
+      InputEvent, DataTransferReadable,

[Xiaocheng, 2016/12/22 06:26:20]

Hmm... This is a behavior change.

We were creating DataTransfers with DragAndDrop and InsertReplacementText for
beforeinput, but now they both become InputEvent.

The working draft doesn't say anything about InputEvent's DataTransfer,
though...

Anyway, could you clarify?

[chongz, 2016/12/22 19:32:26]

Sorry for the confusion, there is actually no behavior change.

Originally |DataTransfer| was used by 2 events:
1. ClipboardEvent
(https://w3c.github.io/clipboard-apis/#clipboard-event-interfaces)
  * e.g. 'copy', 'paste'
2. DragEvent (https://html.spec.whatwg.org/multipage/interaction.html#dragevent)
  * 'e.g. 'dragstart', 'drop', etc.

Now we are adding |InputEvent| which would also use |DataTransfer|.
There is no conflicts because |InputEvent::'deleteByDrag'| etc. are new events
and they are not going to replace drag&drop events.

To help reducing future confusion I think we should change |DataTransferType|
to:
```
enum DataTransferType {
    ClipboardEvent,
    DragEvent,
    InputEvent,
  };
```
Or even just change it to `bool m_isDragEvent;` as we only using it internally
for activating drop effect, etc.

+      DataObject::createFromPlainTextAndHTML(plainText, htmlText));
+}
+
 DataTransfer::~DataTransfer() {}
 
 void DataTransfer::setDropEffect(const String& effect) {
   if (!isForDragAndDrop())
     return;
 
   // The attribute must ignore any attempts to set it to a value other than
   // none, copy, link, and move.
   if (effect != "none" && effect != "copy" && effect != "link" &&
       effect != "move")
@@ skipping 379 matching lines @@
   }
 }
 
 DEFINE_TRACE(DataTransfer) {
   visitor->trace(m_dataObject);
   visitor->trace(m_dragImage);
   visitor->trace(m_dragImageElement);
 }
 
 }  // namespace blink