third_party/WebKit/Source/core/events/InputEvent.h - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/InputEvent.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: xiaocheng's review: Isolate |UndoStep| code; Move attribuates to private Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/InputEvent.h

diff --git a/third_party/WebKit/Source/core/events/InputEvent.h b/third_party/WebKit/Source/core/events/InputEvent.h

index 3d0f4f2e99d264ef0cc202835672f795611b6fd2..9fd55425522a35dfeb917a038dcccbb52170e973 100644

--- a/third_party/WebKit/Source/core/events/InputEvent.h

+++ b/third_party/WebKit/Source/core/events/InputEvent.h

@@ -91,8 +91,7 @@ class InputEvent final : public UIEvent {

const RangeVector*);

static InputEvent* createInput(InputType,

const String& data,

- EventIsComposing,

- const RangeVector*);

Xiaocheng 2016/12/21 02:56:39 It doesn't seem relevant to beforeinput.

chongz 2016/12/21 23:59:24 Reverted, will put in another patch.

+ EventIsComposing);

String inputType() const;

const String& data() const { return m_data; }