Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: third_party/WebKit/Source/core/events/InputEvent.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)
Patch Set: xiaocheng's review: Isolate |UndoStep| code; Move attribuates to private Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef InputEvent_h 5 #ifndef InputEvent_h
6 #define InputEvent_h 6 #define InputEvent_h
7 7
8 #include "core/clipboard/DataTransfer.h" 8 #include "core/clipboard/DataTransfer.h"
9 #include "core/dom/Range.h" 9 #include "core/dom/Range.h"
10 #include "core/dom/StaticRange.h" 10 #include "core/dom/StaticRange.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 EventCancelable, 84 EventCancelable,
85 EventIsComposing, 85 EventIsComposing,
86 const RangeVector*); 86 const RangeVector*);
87 static InputEvent* createBeforeInput(InputType, 87 static InputEvent* createBeforeInput(InputType,
88 DataTransfer*, 88 DataTransfer*,
89 EventCancelable, 89 EventCancelable,
90 EventIsComposing, 90 EventIsComposing,
91 const RangeVector*); 91 const RangeVector*);
92 static InputEvent* createInput(InputType, 92 static InputEvent* createInput(InputType,
93 const String& data, 93 const String& data,
94 EventIsComposing, 94 EventIsComposing);
95 const RangeVector*);
Xiaocheng 2016/12/21 02:56:39 It doesn't seem relevant to beforeinput.
chongz 2016/12/21 23:59:24 Reverted, will put in another patch.
96 95
97 String inputType() const; 96 String inputType() const;
98 const String& data() const { return m_data; } 97 const String& data() const { return m_data; }
99 DataTransfer* dataTransfer() const { return m_dataTransfer.get(); } 98 DataTransfer* dataTransfer() const { return m_dataTransfer.get(); }
100 bool isComposing() const { return m_isComposing; } 99 bool isComposing() const { return m_isComposing; }
101 // Returns a copy of target ranges during event dispatch, and returns an empty 100 // Returns a copy of target ranges during event dispatch, and returns an empty
102 // vector after dispatch. 101 // vector after dispatch.
103 StaticRangeVector getTargetRanges() const; 102 StaticRangeVector getTargetRanges() const;
104 103
105 bool isInputEvent() const override; 104 bool isInputEvent() const override;
(...skipping 23 matching lines...) Expand all
129 explicit InputEventDispatchMediator(InputEvent*); 128 explicit InputEventDispatchMediator(InputEvent*);
130 InputEvent& event() const; 129 InputEvent& event() const;
131 DispatchEventResult dispatchEvent(EventDispatcher&) const override; 130 DispatchEventResult dispatchEvent(EventDispatcher&) const override;
132 }; 131 };
133 132
134 DEFINE_EVENT_TYPE_CASTS(InputEvent); 133 DEFINE_EVENT_TYPE_CASTS(InputEvent);
135 134
136 } // namespace blink 135 } // namespace blink
137 136
138 #endif // InputEvent_h 137 #endif // InputEvent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698