Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/core/events/InputEvent.cpp

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)
Patch Set: Retain the order of firing 'beforeinput' before 'compositionupdate' Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/InputEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/InputEvent.cpp b/third_party/WebKit/Source/core/events/InputEvent.cpp
index 800d5d53fb261e7d999d7f0b17ee459c8dfd2805..6188e5a8c6d1f9a4bbde467531183cc150399c44 100644
--- a/third_party/WebKit/Source/core/events/InputEvent.cpp
+++ b/third_party/WebKit/Source/core/events/InputEvent.cpp
@@ -144,8 +144,7 @@ InputEvent* InputEvent::createBeforeInput(InputType inputType,
/* static */
InputEvent* InputEvent::createInput(InputType inputType,
const String& data,
- EventIsComposing isComposing,
- const RangeVector* ranges) {
+ EventIsComposing isComposing) {
InputEventInit inputEventInit;
inputEventInit.setBubbles(true);
@@ -156,8 +155,6 @@ InputEvent* InputEvent::createInput(InputType inputType,
inputEventInit.setInputType(convertInputTypeToString(inputType));
inputEventInit.setData(data);
inputEventInit.setIsComposing(isComposing == IsComposing);
- if (ranges)
- inputEventInit.setRanges(*ranges);
inputEventInit.setComposed(true);
return InputEvent::create(EventTypeNames::input, inputEventInit);
}

Powered by Google App Engine
This is Rietveld 408576698