third_party/WebKit/Source/core/editing/commands/TypingCommand.h - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: Retain the order of firing 'beforeinput' before 'compositionupdate' Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

index ecc6a3df2097432c17d46c927a6ed7a77490a758..1836cc6b016049ce0a7e33ce1fd73dff689ff3ac 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

@@ -107,8 +107,10 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {

ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }

TextCompositionType compositionType() const { return m_compositionType; }

+ InputEvent::InputType inputType() const final;

Xiaocheng 2016/12/20 05:49:57 Same as for ReplaceSelectionCommand

chongz 2016/12/20 23:27:51 Done.

// Returns text data of the last added typing.

String textDataForInputEvent() const final;

+ RangeVector* targetRangesForInputEvent() const final;

private:

static TypingCommand* create(

@@ -144,7 +146,6 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {

static TypingCommand* lastTypingCommandIfStillOpenForTyping(LocalFrame*);

void doApply(EditingState*) override;

- InputEvent::InputType inputType() const override;

bool isTypingCommand() const override;

bool preservesTypingStyle() const override { return m_preservesTypingStyle; }

void setShouldRetainAutocorrectionIndicator(bool retain) override {