[InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
index 38fde66e32b7bcd58c4e80e2fcf4795095dd2576..3035796c3d4fa490c8877577102184e7b02fb39a 100644
--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
@@ -58,6 +58,10 @@ class CORE_EXPORT ReplaceSelectionCommand final : public CompositeEditCommand {
 
   EphemeralRange insertedRange() const;
 
+  InputEvent::InputType inputType() const final;

[Xiaocheng, 2016/12/20 05:49:57]

What's the reason of exposing these functions?

They should be private if callers should only call them virtually via
CompositeEditCommand's functions.

[chongz, 2016/12/20 23:27:51]

Done.

+  String textDataForInputEvent() const final;
+  DataTransfer* dataTransferForInputEvent() const final;
+
   DECLARE_VIRTUAL_TRACE();
 
  private:
@@ -67,7 +71,6 @@ class CORE_EXPORT ReplaceSelectionCommand final : public CompositeEditCommand {
                           InputEvent::InputType);
 
   void doApply(EditingState*) override;
-  InputEvent::InputType inputType() const override;
   bool isReplaceSelectionCommand() const override;
 
   class InsertedNodes {