third_party/WebKit/Source/core/editing/commands/EditCommand.cpp - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: Retain the order of firing 'beforeinput' before 'compositionupdate' Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

index b82246f8baca4f99f584706f4ba0b1616cb9864d..a8a99ce440bbca0ae1d9a545615c796494fdcf13 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

@@ -44,14 +44,6 @@ EditCommand::EditCommand(Document& document)

EditCommand::~EditCommand() {}

-InputEvent::InputType EditCommand::inputType() const {

- return InputEvent::InputType::None;

-String EditCommand::textDataForInputEvent() const {

- return nullAtom;

static inline EditCommandComposition* compositionIfPossible(

EditCommand* command) {

if (!command->isCompositeEditCommand())