Make old version bots show up yellow on botlist

appengine/swarming/ui/res/imp/botlist/bot-list.html

Index: appengine/swarming/ui/res/imp/botlist/bot-list.html
diff --git a/appengine/swarming/ui/res/imp/botlist/bot-list.html b/appengine/swarming/ui/res/imp/botlist/bot-list.html
index 2d3c7226a81c653fc2980579a167a7a97fba44bf..3553286c73f0abafb2721cf86d3d4705d95ac8d2 100644
--- a/appengine/swarming/ui/res/imp/botlist/bot-list.html
+++ b/appengine/swarming/ui/res/imp/botlist/bot-list.html
@@ -58,6 +58,9 @@
         /* Leave space for sort-toggle*/
         padding-right: 30px;
       }
+      .old_version {
+        background-color: #ffffdd;
+      }
     </style>
 
     <url-param name="s"
@@ -183,7 +186,7 @@
                 as="bot"
                 initial-count=50>
 
-              <tr class$="[[_botClass(bot)]]">
+              <tr class$="[[_botClass(bot,_server_details.bot_version)]]">
                 <td>
                   <a
                       class="center"
@@ -602,13 +605,16 @@
         return swarming.alias.android(this._deviceType(device));
       },
 
-      _botClass: function(bot) {
+      _botClass: function(bot, serverVersion) {
         if (bot.is_dead) {
           return "dead";
         }
         if (bot.quarantined) {
           return "quarantined";
         }
+        if (bot.version !== serverVersion) {

[M-A Ruel, 2016/12/09 20:57:13]

I'd prefer these to be additive.

[kjlubick, 2016/12/12 13:26:11]

Done.

+          return "old_version";
+        }
         return "";
       },