Mark clip paths as a clip-related property

Mark clip paths as a clip-related property

BUG=615870
TEST=Load http://codepen.io/zen-co/pen/jrOxEg and check that the animation is
clipped properly

Committed: https://crrev.com/3de2a45741756dfa0640ce1037a76ee9eedabfbb
Cr-Commit-Position: refs/heads/master@{#437635}

[smcgruer, 2016-12-08 16:55:33]

The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 16:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[smcgruer, 2016-12-08 18:26:12]

smcgruer@chromium.org changed reviewers:
+ chrishtr@chromium.org

[smcgruer, 2016-12-08 18:26:12]

Chris; not sure if you're actively working on crbug.com/615870 . flackr@ had
pointed me to it and I threw this together before realizing the bug was assigned
to you. Also not sure if this is the correct fix, but it seems sensible to me :)

[commit-bot: I haz the power, 2016-12-08 19:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 19:45:46]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-12-09 02:00:28]

chrishtr@chromium.org changed reviewers:
+ schenney@chromium.org

[chrishtr, 2016-12-09 02:00:29]

I reviewed the call sites of this method, and they all seem compatible with your
adjustment.
Looks good. Please add a test demonstrating the fix to 615870.

[smcgruer, 2016-12-09 16:32:16]

On 2016/12/09 02:00:29, chrishtr wrote:
> I reviewed the call sites of this method, and they all seem compatible with
your
> adjustment.
> Looks good. Please add a test demonstrating the fix to 615870.

Thanks. What sort of test is best suited for demonstrating that fix - a
LayoutTest, or is there a unittest somewhere else that is better suited?
(CompositingRequirementsUpdater has no test class I believe).

[chrishtr, 2016-12-09 17:36:42]

On 2016/12/09 at 16:32:16, smcgruer wrote:
> On 2016/12/09 02:00:29, chrishtr wrote:
> > I reviewed the call sites of this method, and they all seem compatible with
your
> > adjustment.
> > Looks good. Please add a test demonstrating the fix to 615870.
> 
> Thanks. What sort of test is best suited for demonstrating that fix - a
LayoutTest, or is there a unittest somewhere else that is better suited?
(CompositingRequirementsUpdater has no test class I believe).

A layout test with clip path and compositing.

[smcgruer, 2016-12-09 18:38:04]

On 2016/12/09 17:36:42, chrishtr wrote:
> A layout test with clip path and compositing.

Added a layout test. It may be better to do this as a .txt expectation to show
that the layers are composited.

[chrishtr, 2016-12-09 19:06:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-09 19:06:04]

lgtm

[commit-bot: I haz the power, 2016-12-09 19:06:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:44:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481310363986760,
"parent_rev": "994b32da9288afc2a96521adfea7bce96cf4fe48", "commit_rev":
"80db6578a76a1ed882aa8331edd966af5edefc90"}

[commit-bot: I haz the power, 2016-12-09 20:44:49]

Description was changed from

==========
Mark clip paths as a clip-related property

BUG=615870

TEST=Load http://codepen.io/zen-co/pen/jrOxEg and check that the animation is
clipped properly
==========

to

==========
Mark clip paths as a clip-related property

BUG=615870

TEST=Load http://codepen.io/zen-co/pen/jrOxEg and check that the animation is
clipped properly

Review-Url: https://codereview.chromium.org/2558633005
==========

[commit-bot: I haz the power, 2016-12-09 20:44:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 14:40:14]

Description was changed from

==========
Mark clip paths as a clip-related property

BUG=615870

TEST=Load http://codepen.io/zen-co/pen/jrOxEg and check that the animation is
clipped properly

Review-Url: https://codereview.chromium.org/2558633005
==========

to

==========
Mark clip paths as a clip-related property

BUG=615870

TEST=Load http://codepen.io/zen-co/pen/jrOxEg and check that the animation is
clipped properly

Committed: https://crrev.com/3de2a45741756dfa0640ce1037a76ee9eedabfbb
Cr-Commit-Position: refs/heads/master@{#437635}
==========

[commit-bot: I haz the power, 2016-12-12 14:40:14]

Patchset 2 (id:??) landed as
https://crrev.com/3de2a45741756dfa0640ce1037a76ee9eedabfbb
Cr-Commit-Position: refs/heads/master@{#437635}