Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2558623003: Linux aura: use all-scroll cursor in place of move (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
sadrul
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux aura: use all-scroll cursor in place of move R=sadrul@chromium.org BUG=671127 Committed: https://crrev.com/f8614e087b47efbc3f359234b461cd2d88833f8a Cr-Commit-Position: refs/heads/master@{#437155}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/base/cursor/cursor_loader_x11.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Tom (Use chromium acct)
sadrul@ PTAL This is a followup patch to https://chromium.googlesource.com/chromium/src/+/16c9f899aa654b5cb868242f2a19ab375b8397f9
4 years ago (2016-12-07 19:14:33 UTC) #2
sadrul
lgtm https://codereview.chromium.org/2558623003/diff/1/ui/base/cursor/cursor_loader_x11.cc File ui/base/cursor/cursor_loader_x11.cc (right): https://codereview.chromium.org/2558623003/diff/1/ui/base/cursor/cursor_loader_x11.cc#newcode93 ui/base/cursor/cursor_loader_x11.cc:93: // use that for now. Is there an ...
4 years ago (2016-12-08 01:19:02 UTC) #6
Tom (Use chromium acct)
On 2016/12/08 01:19:02, sadrul wrote: > lgtm > > https://codereview.chromium.org/2558623003/diff/1/ui/base/cursor/cursor_loader_x11.cc > File ui/base/cursor/cursor_loader_x11.cc (right): > ...
4 years ago (2016-12-08 01:32:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558623003/20001
4 years ago (2016-12-08 01:34:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 02:25:29 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-08 02:28:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8614e087b47efbc3f359234b461cd2d88833f8a
Cr-Commit-Position: refs/heads/master@{#437155}

Powered by Google App Engine
This is Rietveld 408576698