Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: ui/base/cursor/cursor_loader_x11.cc

Issue 2558623003: Linux aura: use all-scroll cursor in place of move (Closed)
Patch Set: Fix comment' Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/cursor/cursor_loader_x11.cc
diff --git a/ui/base/cursor/cursor_loader_x11.cc b/ui/base/cursor/cursor_loader_x11.cc
index 293bba65986e0cf1fa83ac10117d03b48b47aec7..1929d9fe7d25954daf53e433b52aecdb88c32c0d 100644
--- a/ui/base/cursor/cursor_loader_x11.cc
+++ b/ui/base/cursor/cursor_loader_x11.cc
@@ -87,7 +87,11 @@ const char* CursorCssNameFromId(int id) {
case ui::kCursorPointer:
return "left_ptr";
case ui::kCursorMove:
- return "move";
+ // Returning "move" is the correct thing here, but Blink doesn't
+ // make a distinction between move and all-scroll. Other
+ // platforms use a cursor more consistent with all-scroll, so
+ // use that.
+ return "all-scroll";
case ui::kCursorCross:
return "crosshair";
case ui::kCursorHand:
@@ -172,6 +176,7 @@ static const struct {
{ "progress", "left_ptr_watch", XC_watch },
{ "wait", nullptr, XC_watch },
{ "cell", nullptr, XC_plus },
+ { "all-scroll", nullptr, XC_fleur},
{ "crosshair", nullptr, XC_cross },
{ "text", nullptr, XC_xterm },
{ "not-allowed", "crossed_circle", None },
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698