Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 2558583002: Switched feature usage trace events to use the stable feature ID's (Closed)

Created:
4 years ago by Pat Meenan
Modified:
4 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switched feature usage trace events to use the stable feature ID's The trace events for CSS feature usage were using the unstable property ID which doesn't match what is reported in UMA. This change switches the trace events to use the same stable feature ID that is reported to UMA. BUG=671731 Committed: https://crrev.com/9f983fdfad8789c3c70e818d2cb452cd497ac407 Cr-Commit-Position: refs/heads/master@{#436762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Pat Meenan
rbyers@ - PTAL. This is the change to CSS feature ID's discussed in the HTTP ...
4 years ago (2016-12-06 21:01:53 UTC) #2
Rick Byers
LGTM I should have caught this in the original review - sorry.
4 years ago (2016-12-06 21:04:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558583002/1
4 years ago (2016-12-06 21:06:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 22:46:10 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-06 22:49:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f983fdfad8789c3c70e818d2cb452cd497ac407
Cr-Commit-Position: refs/heads/master@{#436762}

Powered by Google App Engine
This is Rietveld 408576698