Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2558583002: Switched feature usage trace events to use the stable feature ID's (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index e8ea148d35c1925ac9fbbdda912a0f0e26c1785e..6c835278bea6a2fe7c45e84f82573b03e2ef3392 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -1226,9 +1226,10 @@ void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID property) {
if (!m_CSSRecorded.quickGet(property)) {
// Note that HTTPArchive tooling looks specifically for this event - see
// https://github.com/HTTPArchive/httparchive/issues/59
+ int sampleId = mapCSSPropertyIdToCSSSampleIdForHistogram(property);
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.feature_usage"),
- "CSSFeatureFirstUsed", "feature", property);
- cssHistogram().count(mapCSSPropertyIdToCSSSampleIdForHistogram(property));
+ "CSSFeatureFirstUsed", "feature", sampleId);
+ cssHistogram().count(sampleId);
m_CSSRecorded.quickSet(property);
}
m_legacyCounter.countCSS(property);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698