Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2558493004: bluetooth: Replace buttons in device table with action links. (Closed)

Created:
4 years ago by mbrunson
Modified:
4 years ago
Reviewers:
scheib, ortuno, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Replace buttons in device table with action links. When a large number of rows are present in the device table, scrolling performance drops considerably. This is due to the table recalculating its size due to button elements being in each row of the table. Replaces buttons in device table with action links to speed up rendering of the device table. BUG=651282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0 Cr-Commit-Position: refs/heads/master@{#437620}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename button to link, merge upstream #

Patch Set 3 : Change handleInspectBtn_ to handleInspectClick_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/resources/bluetooth_internals/bluetooth_internals.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/bluetooth_internals/device_table.js View 1 2 4 chunks +12 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (13 generated)
mbrunson
This is a very small patch.
4 years ago (2016-12-07 19:42:21 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/2558493004/diff/1/chrome/browser/resources/bluetooth_internals/device_table.js File chrome/browser/resources/bluetooth_internals/device_table.js (right): https://codereview.chromium.org/2558493004/diff/1/chrome/browser/resources/bluetooth_internals/device_table.js#newcode124 chrome/browser/resources/bluetooth_internals/device_table.js:124: var inspectButton = document.createElement('a', 'action-link'); nit: Button -> ...
4 years ago (2016-12-07 21:57:49 UTC) #4
scheib
LGTM
4 years ago (2016-12-07 23:21:22 UTC) #6
ortuno
lgtm
4 years ago (2016-12-08 00:00:45 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2538653002 Patch 320001). Please resolve the dependency and ...
4 years ago (2016-12-08 01:21:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558493004/20001
4 years ago (2016-12-09 18:11:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558493004/40001
4 years ago (2016-12-09 18:16:22 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 20:24:59 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-12 14:37:17 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0
Cr-Commit-Position: refs/heads/master@{#437620}

Powered by Google App Engine
This is Rietveld 408576698