Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2558443002: Move code-stub-assembler.h includes from builtins-utils.h to respective .cc files. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move code-stub-assembler.h includes from builtins-utils.h to respective .cc files. BUG= Committed: https://crrev.com/5fad6a80757e26ad11615d46df5d85388c720e86 Cr-Commit-Position: refs/heads/master@{#41511}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M src/builtins/builtins-array.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-boolean.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-conversion.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-date.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-global.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-internal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-iterator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-math.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-promise.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-symbol.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-typedarray.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-utils.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-06 10:34:16 UTC) #5
epertoso
https://codereview.chromium.org/2558443002/diff/20001/src/builtins/builtins-utils.h File src/builtins/builtins-utils.h (right): https://codereview.chromium.org/2558443002/diff/20001/src/builtins/builtins-utils.h#newcode11 src/builtins/builtins-utils.h:11: #include "src/code-stub-assembler.h" Remove it from here?
4 years ago (2016-12-06 10:38:17 UTC) #6
Igor Sheludko
https://codereview.chromium.org/2558443002/diff/20001/src/builtins/builtins-utils.h File src/builtins/builtins-utils.h (right): https://codereview.chromium.org/2558443002/diff/20001/src/builtins/builtins-utils.h#newcode11 src/builtins/builtins-utils.h:11: #include "src/code-stub-assembler.h" On 2016/12/06 10:38:17, epertoso wrote: > Remove ...
4 years ago (2016-12-06 10:43:46 UTC) #7
epertoso
lgtm
4 years ago (2016-12-06 10:45:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558443002/40001
4 years ago (2016-12-06 10:46:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-06 11:08:29 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 11:09:04 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fad6a80757e26ad11615d46df5d85388c720e86
Cr-Commit-Position: refs/heads/master@{#41511}

Powered by Google App Engine
This is Rietveld 408576698