Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2551163003: [turbofan] Move CodeAssembler::Label and CodeAssembler::Variable to compiler namespace. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move CodeAssembler::Label and CodeAssembler::Variable to compiler namespace. This allows us to forward declare Label and Variable classes without including the code-assembler.h. BUG= Committed: https://crrev.com/df2fc5ef57666b850f94ec13e5d6cf877722be87 Cr-Commit-Position: refs/heads/master@{#41509}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -83 lines) Patch
M src/code-stubs.h View 4 chunks +11 lines, -5 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -0 lines 2 comments Download
M src/compiler/code-assembler.h View 7 chunks +51 lines, -36 lines 0 comments Download
M src/compiler/code-assembler.cc View 7 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/compiler/test-code-assembler.cc View 9 chunks +19 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-06 09:39:06 UTC) #5
epertoso
https://codereview.chromium.org/2551163003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/2551163003/diff/1/src/code-stubs-hydrogen.cc#newcode11 src/code-stubs-hydrogen.cc:11: #include "src/code-stub-assembler.h" Why?
4 years ago (2016-12-06 09:47:01 UTC) #6
Igor Sheludko
https://codereview.chromium.org/2551163003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/2551163003/diff/1/src/code-stubs-hydrogen.cc#newcode11 src/code-stubs-hydrogen.cc:11: #include "src/code-stub-assembler.h" On 2016/12/06 09:47:01, epertoso wrote: > Why? ...
4 years ago (2016-12-06 09:49:26 UTC) #7
epertoso
lgtm
4 years ago (2016-12-06 10:26:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551163003/1
4 years ago (2016-12-06 10:27:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 10:29:20 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 10:29:53 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df2fc5ef57666b850f94ec13e5d6cf877722be87
Cr-Commit-Position: refs/heads/master@{#41509}

Powered by Google App Engine
This is Rietveld 408576698