Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558433002:
FontResource: use DCHECKs for confirmed CHECKs (Closed)
|
Created:
4 years ago by Takashi Toyoshima Modified:
4 years ago Reviewers:
yhirano CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFontResource: use DCHECKs for confirmed CHECKs
We used CHECKs to confirm if these checks are valid and can survive
on Canary. Now that we know these are correct, let's make it back
to DCHECKs.
BUG=670638
Committed: https://crrev.com/87524014534512f530c216924f9d500fb89781de
Cr-Commit-Position: refs/heads/master@{#437510}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== FontResource: use DCHECKs for confirmed CHECKs We used CHECKs to confirm if these checks are valid and can survive on Canary. Now that we know these are correct, let's make it back to DCHECKs. BUG=670638 ========== to ========== FontResource: use DCHECKs for confirmed CHECKs We used CHECKs to confirm if these checks are valid and can survive on Canary. Now that we know these are correct, let's make it back to DCHECKs. BUG=670638 ==========
toyoshim@chromium.org changed reviewers: + yhirano@chromium.org
ptal
lgtm
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481276178261860, "parent_rev":
"956af94b0279979bc8d6f1cefced7c49885e3d4f", "commit_rev":
"f2eb151d07d91d2458219a3f66df0b138d1643e9"}
Message was sent while issue was closed.
Description was changed from ========== FontResource: use DCHECKs for confirmed CHECKs We used CHECKs to confirm if these checks are valid and can survive on Canary. Now that we know these are correct, let's make it back to DCHECKs. BUG=670638 ========== to ========== FontResource: use DCHECKs for confirmed CHECKs We used CHECKs to confirm if these checks are valid and can survive on Canary. Now that we know these are correct, let's make it back to DCHECKs. BUG=670638 Review-Url: https://codereview.chromium.org/2558433002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== FontResource: use DCHECKs for confirmed CHECKs We used CHECKs to confirm if these checks are valid and can survive on Canary. Now that we know these are correct, let's make it back to DCHECKs. BUG=670638 Review-Url: https://codereview.chromium.org/2558433002 ========== to ========== FontResource: use DCHECKs for confirmed CHECKs We used CHECKs to confirm if these checks are valid and can survive on Canary. Now that we know these are correct, let's make it back to DCHECKs. BUG=670638 Committed: https://crrev.com/87524014534512f530c216924f9d500fb89781de Cr-Commit-Position: refs/heads/master@{#437510} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/87524014534512f530c216924f9d500fb89781de Cr-Commit-Position: refs/heads/master@{#437510} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
