Issue 255843004: Update trackpad pinch-zoom code for corrected scale semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255843004: Update trackpad pinch-zoom code for corrected scale semantics (Closed)

Created:
6 years, 8 months ago by Rick Byers

Modified:
6 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update trackpad pinch-zoom code for corrected scale semantics In https://codereview.chromium.org/254783004 the semantics of the scale parameter for GesturePinchUpdate on Mac is being corrected to be a scale factor (1.0 no zoom) instead of a weird magnification value (where 0 means no zoom). This is important because GesturePinchUpdate events are coalesced together by multipling (not adding) their scale values. This CL updates the browser zoom logic to compensate for this change in scale values. BUG=289887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266556

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/web_contents/web_contents_impl_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Rick Byers

jochen@, please take a look at this little change. The change is trivial but it ...

6 years, 8 months ago (2014-04-25 21:09:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/255843004/1

6 years, 7 months ago (2014-04-28 13:29:16 UTC) #4

Message was sent while issue was closed.

Change committed as 266556

Expand Messages | Collapse Messages