Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 254783004: Fix pinchUpdate scale semantics (Closed)

Created:
6 years, 8 months ago by Rick Byers
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Fix pinchUpdate scale semantics We expect the 'scale' value for GesturePinchUpdate to be a scale factor (with 1.0 meaning no scaling). The Cocoa API docs say you must add 1.0 to the magnification value to get the scale factor. BUG=289887 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebInputEventFactoryMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Rick Byers
Adam, please take a look. I originally planned on fixing this via an ugly 5-sided ...
6 years, 8 months ago (2014-04-25 21:07:15 UTC) #1
abarth-chromium
LGTM assuming the chromium side contains a test.
6 years, 8 months ago (2014-04-25 22:19:58 UTC) #2
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 7 months ago (2014-04-28 13:28:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/254783004/1
6 years, 7 months ago (2014-04-28 13:29:11 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:39:42 UTC) #5
Message was sent while issue was closed.
Change committed as 172763

Powered by Google App Engine
This is Rietveld 408576698