Renamed FaviconHandlerDelegate to FaviconDriver.

Renamed FaviconHandlerDelegate to FaviconDriver.

Note:
Currently FaviconTabHelper implements both FaviconClient and FaviconDriver.
A follow up CL will create a ContentFaviconDriver class that implements
FaviconDriver. FaviconTabHelper will then own an instance of the
ContentFaviconDriver, instead of inheriting from FaviconDriver.

BUG=362074
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266551

[jif, 2014-04-28 08:53:34]

PTAL

[blundell, 2014-04-28 08:59:27]

https://codereview.chromium.org/255843002/diff/1/chrome/browser/favicon/favic...
File chrome/browser/favicon/favicon_handler.h (right):

https://codereview.chromium.org/255843002/diff/1/chrome/browser/favicon/favic...
chrome/browser/favicon/favicon_handler.h:90: FaviconDriver* delegate,
delegate should be changed to driver everywhere.

https://codereview.chromium.org/255843002/diff/1/chrome/browser/favicon/favic...
File chrome/browser/favicon/favicon_handler_unittest.cc (right):

https://codereview.chromium.org/255843002/diff/1/chrome/browser/favicon/favic...
chrome/browser/favicon/favicon_handler_unittest.cc:587: TestFaviconDriver
delegate;
Rename this variable to driver everywhere in this file.

https://codereview.chromium.org/255843002/diff/1/components/favicon/core/favi...
File components/favicon/core/favicon_driver.h (right):

https://codereview.chromium.org/255843002/diff/1/components/favicon/core/favi...
components/favicon/core/favicon_driver.h:15: // This class provides a delegate
interface for a FaviconHandler.  It allows the
This comment should be updated: look at e.g. the comment for AutofillDriver.

https://codereview.chromium.org/255843002/diff/1/components/favicon/core/favi...
components/favicon/core/favicon_driver.h:34: // Notifies the delegate that the
favicon for the active entry was updated.
delegate should be changed to driver everywhere.

[jif, 2014-04-28 10:07:19]

https://codereview.chromium.org/255843002/diff/1/chrome/browser/favicon/favic...
File chrome/browser/favicon/favicon_handler.h (right):

https://codereview.chromium.org/255843002/diff/1/chrome/browser/favicon/favic...
chrome/browser/favicon/favicon_handler.h:90: FaviconDriver* delegate,
On 2014/04/28 08:59:28, blundell wrote:
> delegate should be changed to driver everywhere.

Done.
"git grep -i delegate components/favicon" now returns nothing.

https://codereview.chromium.org/255843002/diff/1/components/favicon/core/favi...
File components/favicon/core/favicon_driver.h (right):

https://codereview.chromium.org/255843002/diff/1/components/favicon/core/favi...
components/favicon/core/favicon_driver.h:15: // This class provides a delegate
interface for a FaviconHandler.  It allows the
On 2014/04/28 08:59:28, blundell wrote:
> This comment should be updated: look at e.g. the comment for AutofillDriver.

Done.

https://codereview.chromium.org/255843002/diff/1/components/favicon/core/favi...
components/favicon/core/favicon_driver.h:34: // Notifies the delegate that the
favicon for the active entry was updated.
On 2014/04/28 08:59:28, blundell wrote:
> delegate should be changed to driver everywhere.

Done.

[blundell, 2014-04-28 10:09:20]

LGTM

[jif, 2014-04-28 10:35:43]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-04-28 10:36:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jif@chromium.org/255843002/20001

[jif, 2014-04-28 10:59:28]

The CQ bit was unchecked by jif@chromium.org

[jif, 2014-04-28 12:31:11]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-04-28 12:32:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jif@chromium.org/255843002/20001

[commit-bot: I haz the power, 2014-04-28 14:00:53]

Change committed as 266551