Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: components/favicon/core/favicon_driver.h

Issue 255843002: Renamed FaviconHandlerDelegate to FaviconDriver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed leftovers. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/favicon.gypi ('k') | components/favicon/core/favicon_handler_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_DELEGATE_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_DELEGATE_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
7 7
8 class GURL; 8 class GURL;
9 9
10 namespace content { 10 namespace content {
11 // TODO(jif): Abstract the NavigationEntry (crbug.com/359598). 11 // TODO(jif): Abstract the NavigationEntry (crbug.com/359598).
12 class NavigationEntry; 12 class NavigationEntry;
13 } 13 }
14 14
15 // This class provides a delegate interface for a FaviconHandler. It allows the 15 // Interface that allows Favicon core code to interact with its driver (i.e.,
16 // FaviconHandler to ask its delegate for information or notify its delegate 16 // obtain information from it and give information to it). A concrete
17 // about changes. 17 // implementation must be provided by the driver.
18 class FaviconHandlerDelegate { 18 class FaviconDriver {
19 public: 19 public:
20 // Returns the current NavigationEntry. 20 // Returns the current NavigationEntry.
21 // TODO(jif): Abstract the NavigationEntry (crbug.com/359598). 21 // TODO(jif): Abstract the NavigationEntry (crbug.com/359598).
22 virtual content::NavigationEntry* GetActiveEntry() = 0; 22 virtual content::NavigationEntry* GetActiveEntry() = 0;
23 23
24 // Starts the download for the given favicon. When finished, the delegate 24 // Starts the download for the given favicon. When finished, the driver
25 // will call OnDidDownloadFavicon() with the results. 25 // will call OnDidDownloadFavicon() with the results.
26 // Returns the unique id of the download request. The id will be passed 26 // Returns the unique id of the download request. The id will be passed
27 // in OnDidDownloadFavicon(). 27 // in OnDidDownloadFavicon().
28 // Bitmaps with pixel sizes larger than |max_bitmap_size| are filtered out 28 // Bitmaps with pixel sizes larger than |max_bitmap_size| are filtered out
29 // from the bitmap results. If there are no bitmap results <= 29 // from the bitmap results. If there are no bitmap results <=
30 // |max_bitmap_size|, the smallest bitmap is resized to |max_bitmap_size| and 30 // |max_bitmap_size|, the smallest bitmap is resized to |max_bitmap_size| and
31 // is the only result. A |max_bitmap_size| of 0 means unlimited. 31 // is the only result. A |max_bitmap_size| of 0 means unlimited.
32 virtual int StartDownload(const GURL& url, int max_bitmap_size) = 0; 32 virtual int StartDownload(const GURL& url, int max_bitmap_size) = 0;
33 33
34 // Notifies the delegate that the favicon for the active entry was updated. 34 // Notifies the driver that the favicon for the active entry was updated.
35 // |icon_url_changed| is true if a favicon with a different icon URL has 35 // |icon_url_changed| is true if a favicon with a different icon URL has
36 // been selected since the previous call to NotifyFaviconUpdated(). 36 // been selected since the previous call to NotifyFaviconUpdated().
37 virtual void NotifyFaviconUpdated(bool icon_url_changed) = 0; 37 virtual void NotifyFaviconUpdated(bool icon_url_changed) = 0;
38 38
39 // Returns whether the user is operating in an off-the-record context. 39 // Returns whether the user is operating in an off-the-record context.
40 virtual bool IsOffTheRecord() = 0; 40 virtual bool IsOffTheRecord() = 0;
41 }; 41 };
42 42
43 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_DELEGATE_H_ 43 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
OLDNEW
« no previous file with comments | « components/favicon.gypi ('k') | components/favicon/core/favicon_handler_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698