Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2558413002: Force Python LF checkout in .gitattributes. (Closed)

Created:
4 years ago by Jamie Madill
Modified:
4 years ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force Python LF checkout in .gitattributes. This will fix Windows python license check presubmit errors. It will ensure the presubmit check always sees "LF" line ending. BUG=669941 Committed: https://crrev.com/d5c8719e7beef69e67f90146a2a532c4abe66944 Cr-Commit-Position: refs/heads/master@{#437871}

Patch Set 1 #

Patch Set 2 : Apply to python only #

Total comments: 1

Patch Set 3 : Address review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M .gitattributes View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Jamie Madill
Dirk, PTAL. Can you suggest one of the *.* reviewers?
4 years ago (2016-12-08 21:13:27 UTC) #5
Dirk Pranke
https://codereview.chromium.org/2558413002/diff/20001/.gitattributes File .gitattributes (right): https://codereview.chromium.org/2558413002/diff/20001/.gitattributes#newcode5 .gitattributes:5: # http://crbug.com/342064 I would delete lines 1-6, and line ...
4 years ago (2016-12-08 21:34:22 UTC) #6
Jamie Madill
jam@, PTAL at the change to OWNERS.
4 years ago (2016-12-09 17:54:23 UTC) #8
jam
lgtm
4 years ago (2016-12-10 00:04:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558413002/40001
4 years ago (2016-12-12 14:00:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-12 14:56:37 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-12 15:12:15 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5c8719e7beef69e67f90146a2a532c4abe66944
Cr-Commit-Position: refs/heads/master@{#437871}

Powered by Google App Engine
This is Rietveld 408576698