Remove explicit singletonness of ArcBridgeService part 5.

Remove explicit singletonness of ArcBridgeService part 5.

Remove ArcBridgeService::Get().
Now all usage was gone. It's time to delete the function.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Committed: https://crrev.com/74b6eaa14ae0e1a11e3e4b8d5b5802aa615d3601
Cr-Commit-Position: refs/heads/master@{#437816}

[hidehiko, 2016-12-08 15:41:18]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 15:41:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-12-08 15:43:17]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-12-08 15:43:17]

PTAL.

This is the last one, on top of four preparing CLs.
Thank you for review in advance!

- hidehiko

https://codereview.chromium.org/2558313002/diff/1/components/arc/arc_bridge_s...
File components/arc/arc_bridge_service_impl.cc (right):

https://codereview.chromium.org/2558313002/diff/1/components/arc/arc_bridge_s...
components/arc/arc_bridge_service_impl.cc:25: constexpr int64_t
kReconnectDelayInSeconds = 5;
FYI/Off-topic: soon, I'll work on refactoring reconnect code to move it to the
ArcSessionManager. Let's use constexpr base::TimeDelta in the CL.

[commit-bot: I haz the power, 2016-12-08 16:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:10:26]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-12-08 17:38:27]

that was surprisingly straightforward. thanks for splitting off this change in a
way that was easy to review!

lgtm.

https://codereview.chromium.org/2558313002/diff/1/components/arc/arc_bridge_s...
File components/arc/arc_bridge_service.h (left):

https://codereview.chromium.org/2558313002/diff/1/components/arc/arc_bridge_s...
components/arc/arc_bridge_service.h:95: static ArcBridgeService* Get();
\o/

https://codereview.chromium.org/2558313002/diff/1/components/arc/arc_bridge_s...
File components/arc/arc_bridge_service_impl.cc (right):

https://codereview.chromium.org/2558313002/diff/1/components/arc/arc_bridge_s...
components/arc/arc_bridge_service_impl.cc:25: constexpr int64_t
kReconnectDelayInSeconds = 5;
On 2016/12/08 15:43:17, hidehiko wrote:
> FYI/Off-topic: soon, I'll work on refactoring reconnect code to move it to the
> ArcSessionManager. Let's use constexpr base::TimeDelta in the CL.

sgtm, I wrote this before I realized base::TimeDelta was constexpr-able.

[hidehiko, 2016-12-12 03:31:22]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2016-12-12 03:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 04:00:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481513482182410, "parent_rev":
"1f552ca0f121a42cb65f2863efb976ccf35b448d", "commit_rev":
"1cc01a23201137d00d8d5bb97ff49b4ba180d532"}

[commit-bot: I haz the power, 2016-12-12 04:00:56]

Description was changed from

==========
Remove explicit singletonness of ArcBridgeService part 5.

Remove ArcBridgeService::Get().
Now all usage was gone. It's time to delete the function.

BUG=657687
BUG=b/31079732
TEST=Ran bots.
==========

to

==========
Remove explicit singletonness of ArcBridgeService part 5.

Remove ArcBridgeService::Get().
Now all usage was gone. It's time to delete the function.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2558313002
==========

[commit-bot: I haz the power, 2016-12-12 04:00:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 15:10:26]

Description was changed from

==========
Remove explicit singletonness of ArcBridgeService part 5.

Remove ArcBridgeService::Get().
Now all usage was gone. It's time to delete the function.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2558313002
==========

to

==========
Remove explicit singletonness of ArcBridgeService part 5.

Remove ArcBridgeService::Get().
Now all usage was gone. It's time to delete the function.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Committed: https://crrev.com/74b6eaa14ae0e1a11e3e4b8d5b5802aa615d3601
Cr-Commit-Position: refs/heads/master@{#437816}
==========

[commit-bot: I haz the power, 2016-12-12 15:10:26]

Patchset 1 (id:??) landed as
https://crrev.com/74b6eaa14ae0e1a11e3e4b8d5b5802aa615d3601
Cr-Commit-Position: refs/heads/master@{#437816}