Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2558183004: Add merge rules for first read time (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
Reviewers:
gambard
CC:
chromium-reviews, stkhapugin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add merge rules for first read time Also fix the seen merge logic. BUG=651041 Committed: https://crrev.com/27a90aeec4c3930f8d68f8d7dd1d6d2f7d8a64a6 Cr-Commit-Position: refs/heads/master@{#437506}

Patch Set 1 #

Patch Set 2 : fixes #

Total comments: 2

Patch Set 3 : comment #

Patch Set 4 : =0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -61 lines) Patch
M components/reading_list/ios/reading_list_entry.cc View 1 2 chunks +18 lines, -13 lines 0 comments Download
M components/reading_list/ios/reading_list_entry_unittest.cc View 1 2 chunks +2 lines, -21 lines 0 comments Download
M components/reading_list/ios/reading_list_store.h View 1 2 3 1 chunk +17 lines, -5 lines 0 comments Download
M components/reading_list/ios/reading_list_store.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_store_unittest.mm View 1 3 chunks +71 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
Olivier
4 years ago (2016-12-08 16:29:00 UTC) #3
gambard
lgtm with comments https://codereview.chromium.org/2558183004/diff/10001/components/reading_list/ios/reading_list_store.h File components/reading_list/ios/reading_list_store.h (right): https://codereview.chromium.org/2558183004/diff/10001/components/reading_list/ios/reading_list_store.h#newcode85 components/reading_list/ios/reading_list_store.h:85: // - if rhs.creation_time_us == lhs.creation_time_us, ...
4 years ago (2016-12-09 08:06:55 UTC) #4
Olivier
Done, thanks
4 years ago (2016-12-09 09:37:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558183004/50001
4 years ago (2016-12-09 09:38:14 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years ago (2016-12-09 09:47:13 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 09:51:05 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/27a90aeec4c3930f8d68f8d7dd1d6d2f7d8a64a6
Cr-Commit-Position: refs/heads/master@{#437506}

Powered by Google App Engine
This is Rietveld 408576698