Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/reading_list/ios/reading_list_store.h

Issue 2558183004: Add merge rules for first read time (Closed)
Patch Set: =0 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/reading_list/ios/reading_list_store.h
diff --git a/components/reading_list/ios/reading_list_store.h b/components/reading_list/ios/reading_list_store.h
index 4dd3cfe88bc71469738958370b52dfa4afb5b842..c8463c834bd99402e9065d4d7831a9c0541726f5 100644
--- a/components/reading_list/ios/reading_list_store.h
+++ b/components/reading_list/ios/reading_list_store.h
@@ -79,11 +79,23 @@ class ReadingListStore : public syncer::ModelTypeSyncBridge,
// Entries are in increasing order if all the fields respect increasing order.
// - URL must be the same.
// - title must verify rhs.title.compare(lhs.title) >= 0
- // - rhs.creation_time_us >= lhs.creation_time_us
- // - rhs.update_time_us >= lhs.update_time_us
- // - if rhs.update_time_us > lhs.update_time_us, rhs.state can be anything.
- // - if rhs.update_time_us == lhs.update_time_us, rhs.state >= lhs.state in
- // the order UNSEEN, UNREAD, READ.
+ // - creation_time_us:
+ // rhs.creation_time_us >= lhs.creation_time_us
+ // - rhs.first_read_time_us:
+ // if rhs.creation_time_us > lhs.creation_time_us,
+ // rhs.first_read_time_us can be anything.
+ // if rhs.creation_time_us == lhs.creation_time_us
+ // and rhs.first_read_time_us == 0
+ // rhs.first_read_time_us can be anything.
+ // if rhs.creation_time_us == lhs.creation_time_us,
+ // rhs.first_read_time_us <= lhs.first_read_time_us
+ // - update_time_us:
+ // rhs.update_time_us >= lhs.update_time_us
+ // - state:
+ // if rhs.update_time_us > lhs.update_time_us
+ // rhs.state can be anything.
+ // if rhs.update_time_us == lhs.update_time_us
+ // rhs.state >= lhs.state in the order UNSEEN, UNREAD, READ.
static bool CompareEntriesForSync(const sync_pb::ReadingListSpecifics& lhs,
const sync_pb::ReadingListSpecifics& rhs);
« no previous file with comments | « components/reading_list/ios/reading_list_entry_unittest.cc ('k') | components/reading_list/ios/reading_list_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698