Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558183002:
Fix system env being overriden with empty env in lint.py (Closed)
DescriptionAndroid lint: Stop clearing environment variable in lint.py
This was causing different versions of Java JVM other than user's
default.
BUG=669999
Committed: https://crrev.com/51736f819c01746d84284b53e4e270e858d237ea
Cr-Commit-Position: refs/heads/master@{#437577}
Patch Set 1 : Fix #
Messages
Total messages: 27 (18 generated)
Description was changed from ========== Fix system env being overriden with empty. BUG=669999 ========== to ========== Fix system env being overriden with empty env in lint.py. This may cause different versions of Java JVM other than system's default being invoked. BUG=669999 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by zpeng@chromium.org
The CQ bit was unchecked by zpeng@chromium.org
The CQ bit was checked by zpeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
zpeng@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew, PTAL. Thanks!
On 2016/12/07 21:06:58, F wrote: > Hi Andrew, PTAL. Thanks! lgtm
Description was changed from ========== Fix system env being overriden with empty env in lint.py. This may cause different versions of Java JVM other than system's default being invoked. BUG=669999 ========== to ========== Android lint: Stop clearing environment variable in lint.py This was causing different versions of Java JVM other than user's default. BUG=669999 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by zpeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by zpeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by zpeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481301298713460,
"parent_rev": "b367298873834dbde914a45a1b23fa35a92e20b3", "commit_rev":
"d6e7e101efd8a96d2da0e9329f62758ed55b141e"}
Message was sent while issue was closed.
Description was changed from ========== Android lint: Stop clearing environment variable in lint.py This was causing different versions of Java JVM other than user's default. BUG=669999 ========== to ========== Android lint: Stop clearing environment variable in lint.py This was causing different versions of Java JVM other than user's default. BUG=669999 Review-Url: https://codereview.chromium.org/2558183002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Android lint: Stop clearing environment variable in lint.py This was causing different versions of Java JVM other than user's default. BUG=669999 Review-Url: https://codereview.chromium.org/2558183002 ========== to ========== Android lint: Stop clearing environment variable in lint.py This was causing different versions of Java JVM other than user's default. BUG=669999 Committed: https://crrev.com/51736f819c01746d84284b53e4e270e858d237ea Cr-Commit-Position: refs/heads/master@{#437577} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/51736f819c01746d84284b53e4e270e858d237ea Cr-Commit-Position: refs/heads/master@{#437577} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
