Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2558143003: Use UTC rather than local time for interpreting FTP listing dates. (Closed)

Created:
4 years ago by eroman
Modified:
4 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use UTC rather than local time for interpreting FTP listing dates. Both approaches are wrong, as the actual timezone is unknown. The main advantage of using UTC time is that it avoids a bug on Linux (issue 666535). BUG=641096 Committed: https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76 Cr-Commit-Position: refs/heads/master@{#437346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M net/ftp/ftp_directory_listing_parser_ls.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_util.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/ftp/ftp_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
eroman
4 years ago (2016-12-08 18:13:26 UTC) #6
mmenke
LGTM
4 years ago (2016-12-08 18:15:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558143003/1
4 years ago (2016-12-08 18:18:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82497)
4 years ago (2016-12-08 20:06:04 UTC) #11
eroman
looks like bogus failures on trybot, however can't find the failure outputs.... will try again
4 years ago (2016-12-08 20:49:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558143003/1
4 years ago (2016-12-08 20:50:38 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 21:28:05 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 21:29:30 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27f05072359d1862332f695ef9530f5f19da8b76
Cr-Commit-Position: refs/heads/master@{#437346}

Powered by Google App Engine
This is Rietveld 408576698