Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/ftp/ftp_directory_listing_parser_unittest.cc

Issue 2558143003: Use UTC rather than local time for interpreting FTP listing dates. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_unittest.h ('k') | net/ftp/ftp_directory_listing_parser_vms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_directory_listing_parser_unittest.cc
diff --git a/net/ftp/ftp_directory_listing_parser_unittest.cc b/net/ftp/ftp_directory_listing_parser_unittest.cc
index 583426d98d7032b35ce7ea20fa4a293168236397..d6ea3107614485032faa7b5dcb4637e48d321603 100644
--- a/net/ftp/ftp_directory_listing_parser_unittest.cc
+++ b/net/ftp/ftp_directory_listing_parser_unittest.cc
@@ -49,7 +49,7 @@ TEST_P(FtpDirectoryListingParserTest, Parse) {
mock_current_time_exploded.hour = 12;
mock_current_time_exploded.minute = 45;
base::Time mock_current_time(
- base::Time::FromLocalExploded(mock_current_time_exploded));
+ base::Time::FromUTCExploded(mock_current_time_exploded));
SCOPED_TRACE(base::StringPrintf("Test case: %s", param.name));
@@ -109,7 +109,7 @@ TEST_P(FtpDirectoryListingParserTest, Parse) {
EXPECT_EQ(size, entry.size);
base::Time::Exploded time_exploded;
- entry.last_modified.LocalExplode(&time_exploded);
+ entry.last_modified.UTCExplode(&time_exploded);
EXPECT_EQ(year, time_exploded.year);
EXPECT_EQ(month, time_exploded.month);
EXPECT_EQ(day_of_month, time_exploded.day_of_month);
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_unittest.h ('k') | net/ftp/ftp_directory_listing_parser_vms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698