Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2558143002: Remove the enable_task_manager build flag and define. (Closed)

Created:
4 years ago by brettw
Modified:
4 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tburkard+watch_chromium.org, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the enable_task_manager build flag and define. These have been replaced by !android checks. The task manager is enabled on all platforms except Android and iOS, and code in chrome isn't compiled on iOS. BUG=671706 Committed: https://crrev.com/ee486bb1c7a7351039d88ba233ad9eabc94887df Cr-Commit-Position: refs/heads/master@{#437281}

Patch Set 1 #

Patch Set 2 : Includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -140 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 3 chunks +70 lines, -78 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/web_contents_tags.cc View 1 4 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +7 lines, -11 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
brettw
Includes
4 years ago (2016-12-07 18:02:58 UTC) #2
brettw
4 years ago (2016-12-07 18:03:30 UTC) #6
Evan Stade
lgtm
4 years ago (2016-12-08 15:37:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558143002/40001
4 years ago (2016-12-08 17:51:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-08 17:57:01 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 18:00:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee486bb1c7a7351039d88ba233ad9eabc94887df
Cr-Commit-Position: refs/heads/master@{#437281}

Powered by Google App Engine
This is Rietveld 408576698