Remove enable_configuration_policy build define.

Remove enable_configuration_policy build define.

This build flag is always set for non-iOS platforms. The flag is not
overridable in the build and we never test other settings of it. The policy
code is stable and doesn't change.

This patch removes the flag and replaces it with !ios conditionals.

BUG=671706
Committed: https://crrev.com/3865a71a732defdff6b64fd3c0fb2899fa7a05c6
Cr-Commit-Position: refs/heads/master@{#437759}

[brettw, 2016-12-07 20:57:32]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 20:57:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-12-07 23:30:00]

brettw@chromium.org changed reviewers:
+ bartfab@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:37:03]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-12-08 18:53:01]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:53:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:53:35]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2016-12-09 00:54:30]

brettw@chromium.org changed reviewers:
+ atwilson@chromium.org
- bartfab@chromium.org

[Andrew T Wilson (Slow), 2016-12-09 22:58:08]

lgtm

https://codereview.chromium.org/2558043004/diff/1/components/policy/BUILD.gn
File components/policy/BUILD.gn (right):

https://codereview.chromium.org/2558043004/diff/1/components/policy/BUILD.gn#...
components/policy/BUILD.gn:340: }
Not looking that closely at this file - I'm presuming this is basically removing
a conditional and updating indents, but diff is confused.

[brettw, 2016-12-09 23:16:20]

https://codereview.chromium.org/2558043004/diff/1/components/policy/BUILD.gn
File components/policy/BUILD.gn (right):

https://codereview.chromium.org/2558043004/diff/1/components/policy/BUILD.gn#...
components/policy/BUILD.gn:340: }
On 2016/12/09 22:58:08, Andrew T Wilson (Slow) wrote:
> Not looking that closely at this file - I'm presuming this is basically
removing
> a conditional and updating indents, but diff is confused.

Yup, thanks.

[brettw, 2016-12-09 23:16:37]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:17:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-12-09 23:41:41]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-12-09 23:43:36]

Merge

[brettw, 2016-12-09 23:43:38]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-12-09 23:43:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/2558043004/#ps20001
(title: "Merge")

[commit-bot: I haz the power, 2016-12-09 23:44:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:47:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[brettw, 2016-12-10 05:54:48]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-12-10 05:54:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 05:59:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481349288703190,
"parent_rev": "c13e46617ad8b95118476d4127aa5b80fe0b5e1b", "commit_rev":
"c8d09f1139af5c71fcaf3b7218cb433f54bba9ea"}

[commit-bot: I haz the power, 2016-12-10 05:59:55]

Description was changed from

==========
Remove enable_configuration_policy build define.

This build flag is always set for non-iOS platforms. The flag is not
overridable in the build and we never test other settings of it. The policy
code is stable and doesn't change.

This patch removes the flag and replaces it with !ios conditionals.

BUG=671706
==========

to

==========
Remove enable_configuration_policy build define.

This build flag is always set for non-iOS platforms. The flag is not
overridable in the build and we never test other settings of it. The policy
code is stable and doesn't change.

This patch removes the flag and replaces it with !ios conditionals.

BUG=671706

Review-Url: https://codereview.chromium.org/2558043004
==========

[commit-bot: I haz the power, 2016-12-10 05:59:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 15:06:37]

Description was changed from

==========
Remove enable_configuration_policy build define.

This build flag is always set for non-iOS platforms. The flag is not
overridable in the build and we never test other settings of it. The policy
code is stable and doesn't change.

This patch removes the flag and replaces it with !ios conditionals.

BUG=671706

Review-Url: https://codereview.chromium.org/2558043004
==========

to

==========
Remove enable_configuration_policy build define.

This build flag is always set for non-iOS platforms. The flag is not
overridable in the build and we never test other settings of it. The policy
code is stable and doesn't change.

This patch removes the flag and replaces it with !ios conditionals.

BUG=671706

Committed: https://crrev.com/3865a71a732defdff6b64fd3c0fb2899fa7a05c6
Cr-Commit-Position: refs/heads/master@{#437759}
==========

[commit-bot: I haz the power, 2016-12-12 15:06:38]

Patchset 2 (id:??) landed as
https://crrev.com/3865a71a732defdff6b64fd3c0fb2899fa7a05c6
Cr-Commit-Position: refs/heads/master@{#437759}