Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 255813009: PNaCl SIMD documentation: improve documentation on casts and __builtin_convertvector. (Closed)

Created:
6 years, 7 months ago by JF
Modified:
6 years, 7 months ago
Reviewers:
nfullagar1
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

PNaCl SIMD documentation: improve documentation on casts and __builtin_convertvector. R= nfullagar@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=2205 TEST= none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266902

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use 0.6 to showcase truncation. #

Patch Set 3 : Explain truncation. #

Total comments: 2

Patch Set 4 : Number of elements must match. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -28 lines) Patch
M native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html View 1 2 3 3 chunks +30 lines, -15 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst View 1 2 3 3 chunks +31 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
JF
6 years, 7 months ago (2014-04-28 16:41:45 UTC) #1
nfullagar1
https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html File native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html (right): https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html#newcode300 native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html:300: v4u c = __builtin_convertvector(b, v4u); /* c = {0,2,3,0} ...
6 years, 7 months ago (2014-04-28 17:35:23 UTC) #2
JF
https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html File native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html (right): https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html#newcode300 native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html:300: v4u c = __builtin_convertvector(b, v4u); /* c = {0,2,3,0} ...
6 years, 7 months ago (2014-04-28 17:42:54 UTC) #3
nfullagar1
On 2014/04/28 17:42:54, JF wrote: > https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html > File native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html > (right): > > https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html#newcode300 ...
6 years, 7 months ago (2014-04-28 17:48:30 UTC) #4
JF
On 2014/04/28 17:48:30, nfullagar1 wrote: > On 2014/04/28 17:42:54, JF wrote: > > > https://codereview.chromium.org/255813009/diff/1/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html ...
6 years, 7 months ago (2014-04-28 17:52:47 UTC) #5
JF
6 years, 7 months ago (2014-04-28 17:52:51 UTC) #6
nfullagar1
one last detail to add, otherwise lgtm https://codereview.chromium.org/255813009/diff/40001/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html File native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html (right): https://codereview.chromium.org/255813009/diff/40001/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html#newcode294 native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html:294: to convert ...
6 years, 7 months ago (2014-04-29 16:50:50 UTC) #7
JF
https://codereview.chromium.org/255813009/diff/40001/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html File native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html (right): https://codereview.chromium.org/255813009/diff/40001/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html#newcode294 native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html:294: to convert from one type to another, truncating when ...
6 years, 7 months ago (2014-04-29 16:55:38 UTC) #8
JF
The CQ bit was checked by jfb@chromium.org
6 years, 7 months ago (2014-04-29 16:55:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/255813009/60001
6 years, 7 months ago (2014-04-29 16:56:32 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 16:57:33 UTC) #11
Message was sent while issue was closed.
Change committed as 266902

Powered by Google App Engine
This is Rietveld 408576698