third_party/WebKit/Source/web/WebViewImpl.h - Issue 2558113002: Drop-down closes via tap/touch again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2558113002: Drop-down closes via tap/touch again. (Closed)

Patch Set: Always reset the m_lastHiddenPopUp at the end of a GestureTap Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index 66a0cfa7bd7eaba8db52d73f268d62a72507fae9..c8ecf5a2ba8d73fe403c7299e629858485b38f6f 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -667,6 +667,11 @@ class WEB_EXPORT WebViewImpl final

// The popup associated with an input/select element.

RefPtr<WebPagePopupImpl> m_pagePopup;

+ // This stores the last hidden page popup. If a GestureTap attempts to open

+ // the popup that is closed by its previous GestureTapDown, the popup remains

+ // closed.

+ RefPtr<WebPagePopupImpl> m_lastHiddenPagePopup;

Persistent<DevToolsEmulator> m_devToolsEmulator;

std::unique_ptr<PageOverlay> m_pageColorOverlay;