Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2558113002: Drop-down closes via tap/touch again. (Closed)
Patch Set: Always reset the m_lastHiddenPopUp at the end of a GestureTap Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 // associated WM_CHAR event if the keydown was handled. We emulate 660 // associated WM_CHAR event if the keydown was handled. We emulate
661 // this behavior by setting this flag if the keyDown was handled. 661 // this behavior by setting this flag if the keyDown was handled.
662 bool m_suppressNextKeypressEvent; 662 bool m_suppressNextKeypressEvent;
663 663
664 // Represents whether or not this object should process incoming IME events. 664 // Represents whether or not this object should process incoming IME events.
665 bool m_imeAcceptEvents; 665 bool m_imeAcceptEvents;
666 666
667 // The popup associated with an input/select element. 667 // The popup associated with an input/select element.
668 RefPtr<WebPagePopupImpl> m_pagePopup; 668 RefPtr<WebPagePopupImpl> m_pagePopup;
669 669
670 // This stores the last hidden page popup. If a GestureTap attempts to open
671 // the popup that is closed by its previous GestureTapDown, the popup remains
672 // closed.
673 RefPtr<WebPagePopupImpl> m_lastHiddenPagePopup;
674
670 Persistent<DevToolsEmulator> m_devToolsEmulator; 675 Persistent<DevToolsEmulator> m_devToolsEmulator;
671 std::unique_ptr<PageOverlay> m_pageColorOverlay; 676 std::unique_ptr<PageOverlay> m_pageColorOverlay;
672 677
673 // Whether the webview is rendering transparently. 678 // Whether the webview is rendering transparently.
674 bool m_isTransparent; 679 bool m_isTransparent;
675 680
676 // Whether the user can press tab to focus links. 681 // Whether the user can press tab to focus links.
677 bool m_tabsToLinks; 682 bool m_tabsToLinks;
678 683
679 // If set, the (plugin) node which has mouse capture. 684 // If set, the (plugin) node which has mouse capture.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor; 738 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor;
734 }; 739 };
735 740
736 // We have no ways to check if the specified WebView is an instance of 741 // We have no ways to check if the specified WebView is an instance of
737 // WebViewImpl because WebViewImpl is the only implementation of WebView. 742 // WebViewImpl because WebViewImpl is the only implementation of WebView.
738 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 743 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
739 744
740 } // namespace blink 745 } // namespace blink
741 746
742 #endif 747 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698