[wasm] Provide correct eval origin for asm.js code

[wasm] Provide correct eval origin for asm.js code

This CL moves all methods related to scripts and eval origin (HasScript,
GetScript, IsEval, GetEvalOrigin) from JSStackFrame to StackFrameBase,
because it also applies to WasmFrames.
This makes the AppendFileLocation method append the same information to
WasmStackFrames and AsmJsWasmStackFrames than to JSStackFrames.

R=titzer@chromium.org, mstarzinger@chromium.org
BUG=v8:4203
Committed: https://crrev.com/c4057d464511a217851148df862126eea664df33
Cr-Commit-Position: refs/heads/master@{#41642}

[Clemens Hammacher, 2016-12-08 12:23:33]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 12:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 12:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 12:52:01]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-08 12:55:44]

LGTM from my end.

[titzer, 2016-12-12 10:10:44]

lgtm

https://codereview.chromium.org/2557923005/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/2557923005/diff/1/src/messages.h#newcode76
src/messages.h:76: StackFrameBase() {}
Shouldn't you initialize the isolate_ to nullptr here?

[Clemens Hammacher, 2016-12-12 12:12:28]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 12:12:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-12 12:12:37]

https://codereview.chromium.org/2557923005/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/2557923005/diff/1/src/messages.h#newcode76
src/messages.h:76: StackFrameBase() {}
On 2016/12/12 at 10:10:44, titzer wrote:
> Shouldn't you initialize the isolate_ to nullptr here?

All other fields in sub-classes are also uninitialized. This is because
FromFrameArray will later be called on them, initializing all fields.

[commit-bot: I haz the power, 2016-12-12 12:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 12:13:47]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Clemens Hammacher, 2016-12-12 13:03:32]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-12-12 13:03:33]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2557923005/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-12 13:03:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 13:31:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481547812607710,
"parent_rev": "5642a564182cc1b4757af9a4fbdcc3f1bc2bed58", "commit_rev":
"19d62a3dd018e6fc9cee28a854d0c8eb7f3e9649"}

[commit-bot: I haz the power, 2016-12-12 13:31:21]

Description was changed from

==========
[wasm] Provide correct eval origin for asm.js code

This CL moves all methods related to scripts and eval origin (HasScript,
GetScript, IsEval, GetEvalOrigin) from JSStackFrame to StackFrameBase,
because it also applies to WasmFrames.
This makes the AppendFileLocation method append the same information to
WasmStackFrames and AsmJsWasmStackFrames than to JSStackFrames.

R=titzer@chromium.org, mstarzinger@chromium.org
BUG=v8:4203
==========

to

==========
[wasm] Provide correct eval origin for asm.js code

This CL moves all methods related to scripts and eval origin (HasScript,
GetScript, IsEval, GetEvalOrigin) from JSStackFrame to StackFrameBase,
because it also applies to WasmFrames.
This makes the AppendFileLocation method append the same information to
WasmStackFrames and AsmJsWasmStackFrames than to JSStackFrames.

R=titzer@chromium.org, mstarzinger@chromium.org
BUG=v8:4203

Review-Url: https://codereview.chromium.org/2557923005
==========

[commit-bot: I haz the power, 2016-12-12 13:31:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 13:31:43]

Description was changed from

==========
[wasm] Provide correct eval origin for asm.js code

This CL moves all methods related to scripts and eval origin (HasScript,
GetScript, IsEval, GetEvalOrigin) from JSStackFrame to StackFrameBase,
because it also applies to WasmFrames.
This makes the AppendFileLocation method append the same information to
WasmStackFrames and AsmJsWasmStackFrames than to JSStackFrames.

R=titzer@chromium.org, mstarzinger@chromium.org
BUG=v8:4203

Review-Url: https://codereview.chromium.org/2557923005
==========

to

==========
[wasm] Provide correct eval origin for asm.js code

This CL moves all methods related to scripts and eval origin (HasScript,
GetScript, IsEval, GetEvalOrigin) from JSStackFrame to StackFrameBase,
because it also applies to WasmFrames.
This makes the AppendFileLocation method append the same information to
WasmStackFrames and AsmJsWasmStackFrames than to JSStackFrames.

R=titzer@chromium.org, mstarzinger@chromium.org
BUG=v8:4203

Committed: https://crrev.com/c4057d464511a217851148df862126eea664df33
Cr-Commit-Position: refs/heads/master@{#41642}
==========

[commit-bot: I haz the power, 2016-12-12 13:31:44]

Patchset 2 (id:??) landed as
https://crrev.com/c4057d464511a217851148df862126eea664df33
Cr-Commit-Position: refs/heads/master@{#41642}