Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2557743006:
Fix omnibox security icons. (Closed)
DescriptionFix omnibox security icons.
- Previously, a long URL would compress the space available to the
security icon, shrinking the image.
- Add the dangerous icon.
A future change will rework these icons to be properly colored
(hopefully via SVG properties).
BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/ba56be0eb8af3ea64331207859110036c77464cf
Cr-Commit-Position: refs/heads/master@{#439926}
Patch Set 1 #Patch Set 2 : Add warning icon support. #
Messages
Total messages: 31 (21 generated)
Description was changed from ========== Enforce constant size of omnibox security icon. Previously, a long URL would compress the space available to the security icon, shrinking the image. BUG=641508 ========== to ========== Enforce constant size of omnibox security icon. Previously, a long URL would compress the space available to the security icon, shrinking the image. BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
cjgrant@chromium.org changed reviewers: + bshe@chromium.org, mthiesse@chromium.org
I pulled this from the bigger resource file CL, as that's evolved into a lengthy discussion.
lgtm
On 2016/12/08 17:57:51, mthiesse wrote: > lgtm lgtm
The CQ bit was checked by cjgrant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by cjgrant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by cjgrant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cjgrant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enforce constant size of omnibox security icon. Previously, a long URL would compress the space available to the security icon, shrinking the image. BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix omnibox security icons. - Previously, a long URL would compress the space available to the security icon, shrinking the image. - Add the dangerous icon. A future change will rework these icons to be properly colored (hopefully via SVG properties). BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by cjgrant@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@chromium.org, bshe@chromium.org Link to the patchset: https://codereview.chromium.org/2557743006/#ps20001 (title: "Add warning icon support.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482270000490320,
"parent_rev": "5a0cf1066893d9328e0e1fa10c3b282a7d13b02f", "commit_rev":
"c3eb1d200831ac469a8c043e09397eea6793d102"}
Message was sent while issue was closed.
Description was changed from ========== Fix omnibox security icons. - Previously, a long URL would compress the space available to the security icon, shrinking the image. - Add the dangerous icon. A future change will rework these icons to be properly colored (hopefully via SVG properties). BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix omnibox security icons. - Previously, a long URL would compress the space available to the security icon, shrinking the image. - Add the dangerous icon. A future change will rework these icons to be properly colored (hopefully via SVG properties). BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2557743006 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix omnibox security icons. - Previously, a long URL would compress the space available to the security icon, shrinking the image. - Add the dangerous icon. A future change will rework these icons to be properly colored (hopefully via SVG properties). BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2557743006 ========== to ========== Fix omnibox security icons. - Previously, a long URL would compress the space available to the security icon, shrinking the image. - Add the dangerous icon. A future change will rework these icons to be properly colored (hopefully via SVG properties). BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ba56be0eb8af3ea64331207859110036c77464cf Cr-Commit-Position: refs/heads/master@{#439926} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ba56be0eb8af3ea64331207859110036c77464cf Cr-Commit-Position: refs/heads/master@{#439926}
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
